-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gas config to the client.toml #5020
Conversation
@hieuvubk can you please add a changelog to this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, once it's got a changelog!
heh, gotcha covered on it :)
@hieuvubk has this been compiled and tested locally? |
yes, I tested in my locally, can write & cmd can read data from |
" "" :wq :qw
@hieuvubk yeah that would be great, please ping when that has been added and tested against mainnet and I will merge! |
@czarcas7ic Fees added, this is my test tx against mainnet using |
@hieuvubk will merge as soon as you get sim to pass! |
@czarcas7ic It passed after rerunning. Seem st wrong in the last run |
Nice work @hieuvubk , merging! |
* Create config.go fixing * config cmd * format * fix template * overwrite ReadFromClientConfig func: change ClientConfig => OsmosisCustomConfig * format * lint * go work sync * add gas configuration to client.toml * add fees var * format --------- Co-authored-by: Jacob Gadikian <[email protected]>
Closes: #4962
What is the purpose of the change
Save
gas
,gas-prices
,gas-adjustment
intoclient.toml
. So user no more needs to pass gas flags in cmd, it will get data from config.Brief Changelog
ConfigCmd
OsmosisCustomClient
instead ofClientConfig
: the purpose is to integrate some of the fields mentioned aboveFlow
gas
or any field with the commandosmosisd config gas 1000000
gas
flag more. Its will get data that saved inclient.toml
osmosisd config [key] [value]