Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG Workflow #4908

Merged
merged 5 commits into from
Apr 15, 2023
Merged

Add CHANGELOG Workflow #4908

merged 5 commits into from
Apr 15, 2023

Conversation

mattverse
Copy link
Member

Closes: #XXX

What is the purpose of the change

Adds workflow where the CI would fail upon not having CHANGELOG entry in the PR.

The check can be skipped when labeled manually no changelog.

Brief Changelog

Add CHANGELOG Workflow

Testing and Verifying

Tested via this PR

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@mattverse mattverse requested a review from a team as a code owner April 13, 2023 12:38
@github-actions github-actions bot added the T:CI label Apr 13, 2023
@mattverse mattverse added V:state/compatible/backport State machine compatible PR, should be backported no-changelog and removed no-changelog labels Apr 13, 2023
@mattverse
Copy link
Member Author

mattverse commented Apr 13, 2023 •
edited
Loading

Tested via following ways:

p0mvn
p0mvn approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

CHANGELOG.md Outdated Show resolved Hide resolved
@p0mvn p0mvn merged commit 97c9be1 into main Apr 15, 2023
@p0mvn p0mvn deleted the mattverse/changelog-ci branch April 15, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
T:CI V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattverse @p0mvn