-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CL): x/poolmanager spot price query for concentrated liquidity #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/poolmanager
labels
Mar 20, 2023
p0mvn
commented
Mar 20, 2023
p0mvn
commented
Mar 20, 2023
p0mvn
commented
Mar 20, 2023
mattverse
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on moving the spot price query as well to have it depend on pool manager. LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/poolmanager
V:state/breaking
State machine breaking PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://app.clickup.com/t/860pq0nxv
What is the purpose of the change
The current spot price query in
x/gamm
only allows for getting balancer and stableswap spot prices.The data team needs a unified entrypoint for all pools. As a result, we are deprecating
x/gamm
spot price query and moving it tox/poolmanager
.This will also enable querying spot price for any future pool such as #4675
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
?yes