Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/test: LP events for data integration #4680

Merged
merged 19 commits into from
Mar 22, 2023
Merged

refactor/test: LP events for data integration #4680

merged 19 commits into from
Mar 22, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 20, 2023

Closes: https://app.clickup.com/t/860q8rpw7

What is the purpose of the change

This change ensures that LP events contain all of the necessary attributes needed by the data team.

It moves the LP events on the keeper layer in case createPosition and withdrawPosition methods are called outside of the message server in the future.

Brief Changelog

  • ensure all required attributes are present
  • move event emission to the keeper layer
  • encapsulate common logic into a function
  • basic test that events are emitted correctly.

Testing and Verifying

This change added tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Mar 20, 2023
@p0mvn p0mvn marked this pull request as ready for review March 20, 2023 18:10
Base automatically changed from adam/impl-id-in-position-key to main March 21, 2023 17:50
@p0mvn p0mvn closed this Mar 22, 2023
@p0mvn p0mvn reopened this Mar 22, 2023
This reverts commit 4e97875.
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0mvn p0mvn merged commit 717d481 into main Mar 22, 2023
@p0mvn p0mvn deleted the roman/lp-events branch March 22, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants