ci: go mod auto-update runs on push to curr #4666
Conversation
| @@ -8,6 +8,8 @@ | |||
| name: Go Mod Auto Version Update | |||
| on: | |||
| push: | |||
| branches: | |||
| - ${{ github.ref }} | |||
There was a problem hiding this comment.
I think with this syntax the workflow will run only when the push to github.ref is made. However, this variable is only accessible when the workflow is running, so, I suspect, that when GH Actions check if the condition for this workflow is met, it will see github.ref as a blank string, because as I said, this variable is only accessible when workflow is running. I will check if that is indeed like that.
There was a problem hiding this comment.
if I am right, I will check out other ways of how this can be done properly
There was a problem hiding this comment.
yes, this workflow will never run with these changes
There was a problem hiding this comment.
Why is that a problem?
This should be checked once a push is made to the current branch. A push triggers the workflow run where github.ref is accessible
There was a problem hiding this comment.
I understand now. ChatGPT was confusing me here:
Closes: #4660
What is the purpose of the change
Currently,
go.modauto-update runs on push to every branch.Instead, it should be running on push to the current branch.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no