Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto: code-gen upgrade handler v16 #4575

Merged
merged 24 commits into from
Mar 25, 2023
Merged

auto: code-gen upgrade handler v16 #4575

merged 24 commits into from
Mar 25, 2023

Conversation

osmo-bot
Copy link
Contributor

Update report

  • Created a new empty upgrade handler
  • Increased E2E_UPGRADE_VERSION in Makefile by 1
  • Increased OSMOSIS_E2E_UPGRADE_VERSION in .vscode/launch.json by 1

@osmo-bot osmo-bot added C:app-wiring Changes to the app folder C:e2e T:auto Automatic items V:state/breaking State machine breaking PR labels Mar 11, 2023
@p0mvn p0mvn mentioned this pull request Mar 11, 2023
Closed
@czarcas7ic czarcas7ic closed this Mar 20, 2023
@czarcas7ic czarcas7ic reopened this Mar 20, 2023
@czarcas7ic
Copy link
Member

Just uploaded the new docker images, repopened to retrigger CI

@p0mvn p0mvn closed this Mar 22, 2023
@p0mvn p0mvn reopened this Mar 22, 2023
@p0mvn p0mvn closed this Mar 23, 2023
@p0mvn p0mvn reopened this Mar 23, 2023
@p0mvn p0mvn mentioned this pull request Mar 23, 2023
Closed
@p0mvn p0mvn mentioned this pull request Mar 24, 2023
Closed
p0mvn
p0mvn reviewed Mar 25, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
p0mvn
p0mvn reviewed Mar 25, 2023
View reviewed changes
tests/e2e/e2e_test.go
Comment on lines 476 to +478
func (s *IntegrationTestSuite) TestRateLimitingParam() {
if s.skipUpgrade {
s.T().Skip("Skipping IBC tests")
}

s.T().Skip("Skipping RateLimitingParam tests. TODO: fix in https://github.com/osmosis-labs/osmosis/issues/4703")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling to get it fixed in #4703

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v15.x backport patches to v15.x branch and removed V:state/compatible/backport State machine compatible PR, should be backported labels Mar 25, 2023
@p0mvn
Copy link
Member

p0mvn commented Mar 25, 2023

Planning to backport e2e initialization changes only, no state-breaks / go mod updates will be backported

@p0mvn
Copy link
Member

p0mvn commented Mar 25, 2023

What was done in this PR on top of the auto-generated logic:

  • removed all Stride migration logic that is v15-specific
  • disabled rate-limiting param test that relied on v15 upgrade handler logic, ref: fix(e2e): rate limiting contract configuration settings #4703
  • updated e2e config init images for v15
  • changed upgrade handler logic to run migrations before applying any overwrites.
  • bumped up SDK-fork dependency to include config query needed by the Hermes relayer v1.3.0 for health check
  • resolved module replace problems
  • resolved go work sync problems

@p0mvn p0mvn requested a review from czarcas7ic March 25, 2023 23:15
czarcas7ic
czarcas7ic approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/e2e/e2e_test.go Show resolved Hide resolved
@p0mvn p0mvn merged commit 0d75f56 into main Mar 25, 2023
@p0mvn p0mvn deleted the create-pull-request/upgrade-v16 branch March 25, 2023 23:48
mergify bot pushed a commit that referenced this pull request Mar 25, 2023
@osmo-bot @mergify
auto: code-gen upgrade handler v16 (#4575)
a8e2084 
* [create-pull-request] automated change

* add cl to v16

* Update go.mod

* update images

* latest go mod

* epochs

* go mod updates

* updates

* update hermes

* updates

* go mod

* updates

* hermes fix

* upgrade handler updates

* remove stride pool migration tests

* remove stride migration logic from genesis and disable rate limiting tests

* Update go.mod

* lint

* relayer tag

* correct sdk fork bump

---------

Co-authored-by: p0mvn <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: czarcas7ic <[email protected]>
(cherry picked from commit 0d75f56)

# Conflicts:
#	.vscode/launch.json
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	tests/cl-go-client/go.mod
#	tests/cl-go-client/go.sum
#	tests/cl-go-client/main.go
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
@mergify mergify bot mentioned this pull request Mar 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch C:app-wiring Changes to the app folder C:e2e C:x/epochs T:auto Automatic items T:build V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osmo-bot @czarcas7ic @p0mvn