Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade proposal script to localOsmosis #4510

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

niccoloraspa
Copy link
Member

What is the purpose of the change

This pull request adds a submit_upgrade_proposal.sh script to simplify the process of testing software upgrades in localosmosis.

Assuming you have a localosmosis instance running, all you have to do is execute:

./submit_upgrade_proposal.sh <VERSION>
# <VERSION> defaults to V15

The new script automatically creates an upgrade proposal for the specified version and votes "yes" on the proposal.

The README.md has been updated with instructions on how to use the script.

Brief Changelog

  • Added submit_upgrade_proposal.sh script to automate the submission of an upgrade proposal and voting "yes" on the proposal.

  • Updated the documentation to include instructions on how to use the new script.

Testing and Verifying

  • Start localOsmosis instance
  • Execute submit_upgrade_proposal.sh script

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@niccoloraspa niccoloraspa requested a review from ValarDragon March 6, 2023 10:43
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Mar 6, 2023
@niccoloraspa niccoloraspa added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v14.x backport patches to v14.x branch A:backport/v15.x backport patches to v15.x branch and removed C:docs Improvements or additions to documentation labels Mar 6, 2023
@niccoloraspa niccoloraspa requested a review from mattverse March 6, 2023 10:43
@niccoloraspa niccoloraspa changed the title Feat/add localosmosis proposal Add upgrade proposal script to localOsmosis Mar 6, 2023
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Mar 6, 2023
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Nice! I"m sure this is now going to save us so much time in copy pasting propsal commands

OSMOSIS_HOME=$HOME/.osmosisd-local/
RPC_NODE=http://localhost:26657/

# Default upgrade version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Default upgrade version
# Default upgrade version
# Note that this value should be changed depending on the upgrade that's being ran

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@ValarDragon ValarDragon merged commit 0bbe4f5 into main Mar 6, 2023
@ValarDragon ValarDragon deleted the feat/add-localosmosis-proposal branch March 6, 2023 13:59
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
* Add script to submit software-upgrade proposal

* Update README.md

* Update README.md

* Remove unused function

(cherry picked from commit 0bbe4f5)
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
* Add script to submit software-upgrade proposal

* Update README.md

* Update README.md

* Remove unused function

(cherry picked from commit 0bbe4f5)
niccoloraspa added a commit that referenced this pull request Mar 6, 2023
* Add script to submit software-upgrade proposal

* Update README.md

* Update README.md

* Remove unused function

(cherry picked from commit 0bbe4f5)

Co-authored-by: Niccolo Raspa <[email protected]>
niccoloraspa added a commit that referenced this pull request Mar 6, 2023
* Add script to submit software-upgrade proposal

* Update README.md

* Update README.md

* Remove unused function

(cherry picked from commit 0bbe4f5)

Co-authored-by: Niccolo Raspa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v14.x backport patches to v14.x branch A:backport/v15.x backport patches to v15.x branch C:docs Improvements or additions to documentation V:state/compatible/backport State machine compatible PR, should be backported
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants