added RL sliding windows and osmo RLs #4461
Conversation
nicolaslara
added
V:state/breaking
app/upgrades/v15/upgrades.go
Outdated
| {"name":"ATOM-DAY-1","duration":86400,"send_recv":[30,30]}, | ||
| {"name":"ATOM-DAY-2","duration":129600,"send_recv":[30,30]}, | ||
| {"name":"ATOM-WEEK-1","duration":604800,"send_recv":[60,60]}, | ||
| {"name":"ATOM-WEEK-2","duration":907200,"send_recv":[60,60]} |
There was a problem hiding this comment.
Shouldn't name be UOSMO-DAY1 etc?
There was a problem hiding this comment.
Yes! copy/paste mistake
| {"name":"ATOM-DAY","duration":86400,"send_recv":[30,30]}, | ||
| {"name":"ATOM-WEEK","duration":604800,"send_recv":[60,60]} | ||
| {"name":"ATOM-DAY-1","duration":86400,"send_recv":[30,30]}, | ||
| {"name":"ATOM-DAY-2","duration":129600,"send_recv":[30,30]}, |
There was a problem hiding this comment.
Asking to learn: can you please elaborate on the sliding window method and how this change enabled it?
There was a problem hiding this comment.
yes. If we have a limit of 30% every 24h, for example, that means that at the seams (when one period ends and the other begins) you could actually transfer 60%, 30% in the block before, and then 30% in the block after.
To avoid this, we stagger the windows by half the time, so if you tried to do the above, the second quota would prevent it.
|
Also, what's the decision about adding the rate limits for ion? |
|
Please add a changelog entry for this |
I don't think we have one. I think osmo can be considered as implied by https://commonwealth.im/osmosis/discussion/8543-set-ibc-rate-limits as it was listed in all the charts, but prob not the same fore ion? |
* added RL sliding windows and osmo RLs * added missing comma * osmo name * changelog * updated test * removed uosmo until we can get the proper channel value from ibc (cherry picked from commit 03f2a98)
* added RL sliding windows and osmo RLs * added missing comma * osmo name * changelog * updated test * removed uosmo until we can get the proper channel value from ibc (cherry picked from commit 03f2a98) Co-authored-by: Nicolas Lara <[email protected]>
What is the purpose of the change
We had discussed adding sliding windows to rate limits to avoid allowing double the max at the time where the RL falls over. This wasn't included in the original code that was going to accompany the proposal, but adding it here now.
Brief Changelog
Testing and Verifying
all tests pass
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)