Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP spec for F1 Fee architecture #446

Merged
merged 3 commits into from
Dec 2, 2021
Merged

WIP spec for F1 Fee architecture #446

merged 3 commits into from
Dec 2, 2021

Conversation

ValarDragon
Copy link
Member

WIP spec for the F1 fee distribution logic.

All the details described are AFAIK correct / quite efficient, I just think much better descriptions of them are required

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #446 (2e7f9dd) into main (cb32d8a) will increase coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   19.00%   20.15%   +1.15%     
==========================================
  Files         144      163      +19     
  Lines       22505    23349     +844     
==========================================
+ Hits         4277     4707     +430     
- Misses      17484    17884     +400     
- Partials      744      758      +14     
Impacted Files Coverage Δ
x/lockup/client/cli/flags.go 50.00% <0.00%> (-50.00%) ⬇️
x/incentives/genesis.go 77.77% <0.00%> (-22.23%) ⬇️
x/lockup/client/cli/query.go 58.35% <0.00%> (-15.24%) ⬇️
x/incentives/keeper/gauge.go 59.70% <0.00%> (-8.96%) ⬇️
x/lockup/keeper/store.go 94.73% <0.00%> (-5.27%) ⬇️
x/lockup/keeper/legacy.go 60.52% <0.00%> (-2.74%) ⬇️
store/tree.go 60.00% <0.00%> (-2.40%) ⬇️
x/lockup/keeper/utils.go 100.00% <0.00%> (ø)
x/incentives/types/gauge.go 0.00% <0.00%> (ø)
x/incentives/abci.go
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb32d8a...2e7f9dd. Read the comment docs.

@ValarDragon
Copy link
Member Author

Going to go ahead and merge this, and then correct it with the turnpike PR

@ValarDragon ValarDragon marked this pull request as ready for review December 2, 2021 16:57
@ValarDragon ValarDragon merged commit df577b7 into main Dec 2, 2021
@ValarDragon ValarDragon deleted the dev/F1_spec branch December 2, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants