Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uosmo, uion denom metadata #4250

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Add uosmo, uion denom metadata #4250

merged 4 commits into from
Feb 9, 2023

Conversation

stackman27
Copy link
Contributor

Closes: #4224

What is the purpose of the change

Add denom metadata for uosmo, uion

Brief Changelog

  • Add denom metadata for uosmo, uion

Testing and Verifying

tested in upgrade handler

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Feb 7, 2023
@stackman27 stackman27 added the V:state/breaking State machine breaking PR label Feb 7, 2023
Comment on lines +68 to +80
{
Denom: appParams.BaseCoinUnit,
Exponent: 0,
Aliases: nil,
},
{
Denom: appParams.HumanCoinUnit,
Exponent: appParams.OsmoExponent,
Aliases: nil,
},
},
Base: appParams.BaseCoinUnit,
Display: appParams.HumanCoinUnit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that these AppParams are const's, so no need to worry about anything in build editing them

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @ValarDragon 's testing recommendation has been added

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add changelog entry for this

@ValarDragon ValarDragon added the A:backport/v15.x backport patches to v15.x branch label Feb 8, 2023
@stackman27
Copy link
Contributor Author

addressed all comments!

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/upgrades/v15/upgrade_test.go Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ValarDragon ValarDragon merged commit 34a0046 into main Feb 9, 2023
@ValarDragon ValarDragon deleted the sis/addmetadata branch February 9, 2023 06:01
mergify bot pushed a commit that referenced this pull request Feb 9, 2023
* added metadata

* added tests for metadata

* matt and dev feedback

* Apply suggestions from code review

Co-authored-by: Matt, Park <[email protected]>

---------

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
(cherry picked from commit 34a0046)
ValarDragon pushed a commit that referenced this pull request Feb 9, 2023
* added metadata

* added tests for metadata

* matt and dev feedback

* Apply suggestions from code review

Co-authored-by: Matt, Park <[email protected]>

---------

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
(cherry picked from commit 34a0046)

Co-authored-by: Sishir Giri <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v15.x backport patches to v15.x branch C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants