-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] Create stableswap and cl pools #4175
[E2E] Create stableswap and cl pools #4175
Conversation
delete redundant Co-authored-by: Roman <[email protected]>
…com/notional-labs/osmosis into minh/create-stableswap-and-cl-pools
There is no need to commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when comments addressed. Please, reset rate_limiter.wasm
to the commit of development:
git checkout <latest main commit hash> -- <path to rate limiter>
seems like this wasm file is deleted from main branch since this commit #4208 |
I see, SG, I think then you may merge main to this PR and the issue is solved! Lmk when this is ready! |
Co-authored-by: Ruslan Akhtariev <[email protected]>
Co-authored-by: Ruslan Akhtariev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only thing is rate_limiter.wasm
file. Can you please pull changes from main, I think it should be gone then?
@@ -35,4 +35,7 @@ var ( | |||
// creation in case more pools are added to genesis | |||
// in the future | |||
PreUpgradePoolId uint64 = 2 | |||
// Stableswap pool is created after balance pool, | |||
// so the pool id should be 3. | |||
PreUpgradeStableSwapPoolId uint64 = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed since #4384
Let's make sure that we are not hard-coding this value. Instead, let's get the resulting pool id from CreateStableSwapPool
and persist it until we reach TestStableSwapPostUpgrade
Can you please make a similar update for PreUpgradePoolId
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do something similar with wallet creation where we set it pre-upgrade here:
osmosis/tests/e2e/configurer/upgrade.go
Lines 159 to 163 in 7158199
config.StrideMigrateWallet = chainANode.CreateWalletAndFund(config.StrideMigrateWallet, []string{ | |
fmt.Sprintf("%d%s", amountOfEachTokenToLP, initialization.StOsmoDenom), | |
fmt.Sprintf("%d%s", amountOfEachTokenToLP, initialization.StJunoDenom), | |
fmt.Sprintf("%d%s", amountOfEachTokenToLP, initialization.StStarsDenom), | |
}) |
and then use here in tests:
Line 1116 in 7158199
node.BankSend(token, initialization.ValidatorWalletName, config.StrideMigrateWallet) |
We should have similar logic for pool ids because now we create pools with ids 1 to 833 in genesis. So your stabelswap pool number is likely to be 835 or so
Hi @phamminh0811 . Do you have any updates here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work
Hi @phamminh0811 . Can you please resolve conflicts here? Let's get this in |
hi @p0mvn , I have resolved those conflicts, please check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you
* Create stableswap pools and CL pools * Refactor code to make sure e2e test upgrading run well * Update tests/e2e/configurer/chain/commands.go delete redundant Co-authored-by: Roman <[email protected]> * Remove CL pool and change stable token denom * renome debug bin * Remove rate limiter * resolve compile osmosis amd64 for linux error * resolve conflict * Update stablepool Co-authored-by: Ruslan Akhtariev <[email protected]> * update create function name Co-authored-by: Ruslan Akhtariev <[email protected]> * rename create stableswap function * add rate_limiter.wasm * Update whitespace error * add some logic to execute a swap * update wasm file * Add stableswap pool test to e2e * Change TestStableSwapPostUpgrade to try swapping the pool created in post upgrade * avoid hard code on e2e test * fix conflict * Delete go.work.sum --------- Co-authored-by: Roman <[email protected]> Co-authored-by: Ruslan Akhtariev <[email protected]> (cherry picked from commit c99200b) # Conflicts: # tests/e2e/e2e_test.go
Co-authored-by: Roman <[email protected]>
* Create stableswap pools and CL pools * Refactor code to make sure e2e test upgrading run well * Update tests/e2e/configurer/chain/commands.go delete redundant Co-authored-by: Roman <[email protected]> * Remove CL pool and change stable token denom * renome debug bin * Remove rate limiter * resolve compile osmosis amd64 for linux error * resolve conflict * Update stablepool Co-authored-by: Ruslan Akhtariev <[email protected]> * update create function name Co-authored-by: Ruslan Akhtariev <[email protected]> * rename create stableswap function * add rate_limiter.wasm * Update whitespace error * add some logic to execute a swap * update wasm file * Add stableswap pool test to e2e * Change TestStableSwapPostUpgrade to try swapping the pool created in post upgrade * avoid hard code on e2e test * fix conflict * Delete go.work.sum --------- Co-authored-by: Roman <[email protected]> Co-authored-by: Ruslan Akhtariev <[email protected]>
Closes: #3742
What is the purpose of the change
This pull request add CreateStableSwapPool function to e2e test and also create stableswap and CL pools to setup test
Testing and Verifying
This change is already covered by existing tests.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)