-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override QueryFnName #4132
override QueryFnName #4132
Conversation
Oh, we'll move those queries to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vuong177! Thanks for the PR
Thanks, @vuong177 . Can you please make this change for Also, please confirm that manual tests have been done |
yep, @p0mvn. This is a log when I try to query in mainnet. It's good. estimate-swap-exact-amount :
estimate-swap-exact-amount-out :
I also add CustomFlagOverrides for those query cmd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing. Thank you
* override QueryFnName * duplicate prepareDescriptor * add CustomFlagOverrides && make change for poolmanager cli (cherry picked from commit e15fc6b) # Conflicts: # x/poolmanager/client/cli/query.go
Co-authored-by: Roman <[email protected]>
Closes: #4084
What is the purpose of the change
EstimateSwapExactAmountIn
.`ParseExpectedQueryFnName
return SwapExactAmountIn instead of EstimateSwapExactAmountIn.Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no) nox/<module>/spec/
) / Osmosis docs repo / not documented) no