Add superfluid unbond partial amount #4107
Conversation
|
Thanks for the PR. Can you please add a changelog entry for this? |
t4sk
changed the title
| // setup superfluid delegations | ||
| _, intermediaryAccs, locks := suite.setupSuperfluidDelegations(valAddrs, []superfluidDelegation{{0, 0, 0, lockAmount}}, denoms) | ||
| suite.checkIntermediaryAccountDelegations(intermediaryAccs) | ||
| suite.Require().True(len(locks) > 0) |
There was a problem hiding this comment.
isn't lock length always = 1 ? If so, can we put it as a variable and then remove the for loop below/
There was a problem hiding this comment.
Yes I can. Alternatively would you like me to test with multiple locks?
|
@t4sk Would it be possible to re-assign me as reviewer once you think the PR is ready for a second round of review? |
|
@mattverse It's ready for another round of review. But I don't have write access to assign reviewers |
x/superfluid/keeper/stake_test.go
Outdated
| unlockAmount sdk.Int | ||
| expectErr bool | ||
| splitLockId bool | ||
| undelegate bool |
There was a problem hiding this comment.
| undelegate bool | |
| undelegating bool |
x/superfluid/keeper/stake_test.go
Outdated
| unlockAmount: sdk.NewInt(1), | ||
| expectErr: true, | ||
| splitLockId: false, | ||
| undelegate: true, |
There was a problem hiding this comment.
| undelegate: true, | |
| undelegating: true, |
x/superfluid/keeper/stake_test.go
Outdated
| unbond: false, | ||
| }, | ||
| { | ||
| name: "undelegate and unbond an undelegated lock", |
There was a problem hiding this comment.
| name: "undelegate and unbond an undelegated lock", | |
| name: "undelegate and unbond an undelegating lock", |
| suite.Require().Equal(newLock.Coins[0].Amount, tc.unlockAmount) | ||
|
|
||
| // check original synthetic lock | ||
| stakingDenom := keeper.StakingSyntheticDenom(lock.Coins[0].Denom, valAddr) |
There was a problem hiding this comment.
Can we also add check for total supply of stake denom to make sure that we have burnt the correct amount?
There was a problem hiding this comment.
I've added code to check the total supply of OSMO. Please let me know if you were thinking of something else
|
Merging this since I can see 2 approvals. Thanks everyone! |
What is the purpose of the change
Implement partial unbonding from superfluid staking
Here is an overview of how
SuperfluidUndelegateAndUnbondLockworks.If the amount to unlock is equal to the underlying locked amount, this function will behave the same as
SuperfluidUndelegatefollowed bySuperfluidUnbondLock. Otherwise this function will create a new synthetic unlocking lock from the newly created underlying lock.Related links
#4059 (comment)
#3830
Brief Changelog
SuperfluidUndelegateAndUnbondLockTesting and Verifying
This change added tests and can be verified as follows:
(example:)
x/superfluid/keeper/stake_test.goDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes)