Add tokens to lock keeper function #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 18.42% 18.47% +0.05%
==========================================
Files 142 142
Lines 22002 22023 +21
==========================================
+ Hits 4053 4068 +15
- Misses 17269 17272 +3
- Partials 680 683 +3
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Aug 12, 2021
x/lockup/keeper/lock.go
Outdated
| @@ -281,6 +281,40 @@ func (k Keeper) UnlockPeriodLockByID(ctx sdk.Context, LockID uint64) (*types.Per | |||
| return lock, err | |||
| } | |||
|
|
|||
| // AddTokensToLock locks more tokens into a lockup | |||
| func (k Keeper) AddTokensToLock(ctx sdk.Context, owner sdk.AccAddress, lockID uint64, coins sdk.Coins) (*types.PeriodLock, error) { | |||
There was a problem hiding this comment.
Can we separate this out into two functions:
AddTokensToLockID(ctx sdk.Context, owner sdk.AccAddress, lockID uint64, coins sdk.Coins)
and
addTokensToLock(ctx, lock *types.PeriodLock, coins sdk.Coins)
I think both will come in handy. The latter doesn't need to publicly exposed, but just separated so it can be called separately.
There was a problem hiding this comment.
Did split the function into two pieces
ValarDragon
reviewed
Aug 12, 2021
ValarDragon
approved these changes
Aug 12, 2021
Co-authored-by: Dev Ojha <[email protected]>
…into add_tokens_to_lock
ValarDragon
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.