[ValSet-Pref] Simulator Fix for RedelegateValSet & UndelegateFromValset #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
|
Task linked: CU-8669c0uzk Simulator Fix |
czarcas7ic
reviewed
Jan 21, 2023
mattverse
reviewed
Jan 21, 2023
x/valset-pref/simulation/sim_msgs.go
Outdated
| }, nil | ||
| } | ||
| if sim.StakingKeeper().HasReceivingRedelegation(ctx, delAddr, val) { | ||
| return nil, fmt.Errorf("receveing redelegation is not allowed for source validators") |
There was a problem hiding this comment.
what does it mean here by "source validators"?
There was a problem hiding this comment.
For redelegation, we need validators to redelegate to(target validators) and validators to redelegate from(source validators).
Comment on lines
+143
to
+145
| if sim.StakingKeeper().HasReceivingRedelegation(ctx, delAddr, val) { | ||
| return nil, fmt.Errorf("receveing redelegation is not allowed for target validators") | ||
| } |
There was a problem hiding this comment.
Why are they not allowed to receive redelegations?
There was a problem hiding this comment.
because this is the clause in redelegation. For ex:
ValA --- redelegation --> ValB
Val --redelegation --> ValC (ERROR: because ValB is receiving redelegation)
|
Addressed your comments @mattverse @czarcas7ic. Ready for rereview! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of : #2579
What is the purpose of the change
Simulator Fix
Logs:
Brief Changelog
n/a
Testing and Verifying
Sim test
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)