Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow whitelisted tx fee tokens based on conversion rate to OSMO #394
Allow whitelisted tx fee tokens based on conversion rate to OSMO #394
Changes from 25 commits
6fed296
63cc9ba
e4ae67c
89af6ce
8c8201d
8901d9d
f86f5df
3621f25
f90b08d
3af3a9f
258e6a5
8752f6f
c35fe59
6031c2f
7570286
f7eb73f
128f6a7
95cb787
3aff950
844a718
2b9c0ef
c34261a
604677b
bece12b
bdd8bd0
0a0f106
e27eccc
fce7334
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out whats going on with tabs in the proto files. I feel like every PR that touches proto files keeps on changing these. Theres some inconsistency somewhere :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the behavior when the denom isn't a fee token? Lets make the response have an explicit field for if the fee token isn't used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a linting issue? Maybe we need a protobuf linter?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.