Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CL): re-enable CL module tests (finalize merge #2) #3913

Merged
merged 2 commits into from
Jan 3, 2023
Merged

chore(CL): re-enable CL module tests (finalize merge #2) #3913

merged 2 commits into from
Jan 3, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jan 3, 2023 •
edited
Loading

@p0mvn p0mvn mentioned this pull request Jan 3, 2023
Closed
9 tasks
@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Jan 3, 2023
@p0mvn p0mvn mentioned this pull request Jan 3, 2023
Closed
@p0mvn p0mvn marked this pull request as ready for review January 3, 2023 20:42
czarcas7ic
czarcas7ic approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I had done this locally on one of the PRs I am working on. Thanks

@p0mvn
Copy link
Member Author

p0mvn commented Jan 3, 2023

ACK, I had done this locally on one of the PRs I am working on. Thanks

Going to merge so that people don't have to investigate why some logic isn't working

@p0mvn p0mvn merged commit b5cad13 into main Jan 3, 2023
@p0mvn p0mvn deleted the roman/cl-enable-tests branch January 3, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
C:x/concentrated-liquidity V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic