[CL]: Add swaprouter queries to stargate whitelist #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
added
the
V:state/compatible/no_backport
mattverse
changed the title
mattverse
requested review from
p0mvn and
czarcas7ic
and removed request for
p0mvn
p0mvn
requested changes
Jan 3, 2023
wasmbinding/stargate_whitelist.go
Outdated
Comment on lines
87
to
88
| setWhitelistedQuery("/osmosis.gamm.v1beta1.Query/EstimateSwapExactAmountIn", &gammtypes.QuerySwapExactAmountInResponse{}) | ||
| setWhitelistedQuery("/osmosis.gamm.v1beta1.Query/EstimateSwapExactAmountOut", &gammtypes.QuerySwapExactAmountOutResponse{}) |
There was a problem hiding this comment.
We still want to keep these to avoid breaking old contracts
There was a problem hiding this comment.
Brought them back for now, do we have further plans to deprecate them for the contracts though? I think it'd be awkward when in long term we support the two same queries but from different modules
There was a problem hiding this comment.
We would need to communicate with the integrators, asking whether anyone is using these.
If contracts are already utilizing some of these, removal from the stargate-whitelist wouldn't be easy so we might have to accept keeping these while there are production users.
Co-authored-by: Roman <[email protected]>
p0mvn
approved these changes
Jan 4, 2023
p0mvn
added
V:state/breaking
|
I marked this as state-breaking to re-review before v15 since this touches the stargate whitelist. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3882
What is the purpose of the change
This PR adds swaprouter queries(namely
Numpools,EstimateSwapExactAmountIn,EstimateSwapExactAmountOut) to stargate query whitelist.Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yesx/<module>/spec/) / Osmosis docs repo / not documented)