refactor(x/swaprouter, x/gamm): unify swap routes in swaprouter

[p0mvn]

Closes: #3808

What is the purpose of the change

This PR removes the swap routes in x/gamm and refactors all legacy x/gamm swap messages and methods to utilize the new swap route structs from the x/swaprouter module.

This is done to reduce code duplication and redundant conversions between the different swap routes.

Brief Changelog

• removed proto declarations for all x/gamm swap routes but SwapExactAmountInRoute
  • It is kept for the serialization / deserialization test but is to be removed in the future.
• substituted usage of old x/gamm swap routes with the x/swaprouter swap routes.

Testing and Verifying

This change added tests and can be verified as follows:

osmosis/x/gamm/types/route_test.go

Line 16 in a3afcda

func TestSwapRoutes_MarshalUnmarshal(t *testing.T) {

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? no
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
• How is the feature or change documented? not applicable

[p0mvn]

While this is not state-breaking, I added the label still to be more careful with this PR as it has an important API break.

[mattverse]

Left one question / concerning point about gamm types. Other then that, looks LGTM

[ValarDragon]

We should ask dan lynch and front-end how breaking this is.

Its not clear to me that its worth breaking this in the gamm proto, vs just doing a conversion in the proto boilerplate handling code.

[ValarDragon]

(I think it will break their compiled types, unless we can register a way for a type to get aliased or something in codegen)

[pyramation]

as long as the interfaces/API don't change, it doesn't matter where the types live. Telescope will handle it.

from what I can see here it looks the the interface to the type doesn't change, so will be totally ok!

cc @p0mvn

[pyramation]

also, even w/o telescope, from what I can tell (since I believe osmosis-fe uses another tool) — nothing should break. But, we should probably all keep in sync when this update rolls out to update FE libs and repos.

[p0mvn]

Thanks, @pyramation . I also spoke with Jon to make sure that there is no unexpected breakage for FE.

We will track this change and remind everyone to update before this is out.

This should be good to go

[ValarDragon]

Needs changelog entry for breaking changes if you worked with queries via JSON, otherwise LGTM.

• (or is it JSON serialization compatible?)

(Maybe we can just add a TODO for us to check when we update front-end, may remove it from being marked as breaking, and then it'd just be a misc improvement)

Its totally fine for contracts, and an easy update, so LGTM!

[p0mvn]

Seems to be JSON serialization compatible based on added test here: 3a46711

[ValarDragon]

oh awesome, thats great!