[ValSet-Pref] Allow migration of x/lockup uosmo to staking to a valset preference #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
stackman27
commented
Dec 21, 2022
stackman27
force-pushed
the
sis/MsgDelBondTok
branch
from
27468f3 to
94c0d3e
Compare
|
Rebased and ready for review @czarcas7ic |
czarcas7ic
reviewed
Jan 2, 2023
mattverse
requested changes
Jan 2, 2023
czarcas7ic
reviewed
Jan 3, 2023
czarcas7ic
reviewed
Jan 3, 2023
stackman27
force-pushed
the
sis/MsgDelBondTok
branch
from
94c0d3e to
0da063d
Compare
mattverse
reviewed
Jan 11, 2023
stackman27
force-pushed
the
sis/MsgDelBondTok
branch
from
dcab3da to
c5a1fdc
Compare
mattverse
reviewed
Jan 17, 2023
stackman27
commented
Jan 17, 2023
x/valset-pref/msg_server_test.go
Outdated
| lockId: testLock[6].ID, | ||
| expectPass: false, | ||
| }, | ||
| { | ||
| name: "Force Unlocks tokens, but doesnot have delegations", |
There was a problem hiding this comment.
removing this because multi message tx reverts are being tested manually cli tested
There was a problem hiding this comment.
do we have plans to add a go test for this or no?
There was a problem hiding this comment.
in the last chain dev call, i think the verdict was to just write e2e test
|
Thank you @mattverse for your feedback resolved everything here: |
|
The lock check in the test and LGTM |
czarcas7ic
approved these changes
Jan 19, 2023
Comment on lines
+270
to
+276
| _, err := sdk.AccAddressFromBech32(m.Delegator) | ||
| if err != nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
nit: maybe in future PR can add check that lockId is positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3703
Part of: Part of : #2579
What is the purpose of the change
We should add a new message in valset preference which allows breaking of a bonded lockup (by ID) of osmo, of length <= 2 weeks, add takes all that osmo and stakes according to your current validator set preference. If you don't have a valset preference, return an error. (Noting that there is an implicit valset preference if you've already staked)
Brief Changelog
n/a
Testing and Verifying
added tests for MsgDelegateBondedTokens
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)