osmomath: `AddMut` and `QuoMut` #3779

pysel · 2022-12-17T10:31:49Z

mut add
test add mut
quo mut
test quo mut/ remove want from test struct

Closes: #3773

What is the purpose of the change

mutative add and quo + tests

ValarDragon · 2022-12-17T17:10:29Z

This isn't getting the speedup benefit of mutative arithmetic. Can you look at how we do it in our SDK fork for Decimal, and adapt it here in a similar style?

pysel · 2022-12-17T19:00:23Z

@ValarDragon I pushed changes, not sure I understood what you mean tho, hope fixed correctly

osmomath/exp2.go

p0mvn · 2022-12-17T20:44:30Z

osmomath/decimal.go

+// mutative quotient
+func (d BigDec) QuoMut(d2 BigDec) BigDec {
+	// multiply precision twice
+	mul := new(big.Int).Mul(d.i, precisionReuse)


We should not allocate new int. One of the goals of the mutative versions is to gain speed up by avoiding reallocations and copying.

Please see:
https://github.com/osmosis-labs/cosmos-sdk/blob/48fe175f983925ff6202d492a363d2b2e3a62497/types/decimal.go#L343-L352

p0mvn · 2022-12-19T15:20:29Z

548207900.mdttt

@@ -0,0 +1,16 @@
+- mut add


Let's remove this

osmomath/exp2.go

p0mvn · 2022-12-19T15:22:58Z

osmomath/decimal_test.go

+		} else {
+			save := tc.testing
+
+			require.Panics(t, func() { tc.testing.QuoMut(tc.quo) })


We have a helper for this here:

osmosis/osmomath/export_test.go

Line 25 in 6206709

func ConditionalPanic(t *testing.T, expectPanic bool, sut func()) {

osmomath/decimal.go

p0mvn · 2022-12-19T15:25:59Z

osmomath/decimal_test.go

@@ -38,6 +38,59 @@ func (s *decimalTestSuite) assertMutResult(expectedResult, startValue, mutativeR
 	s.Require().Equal(nonMutativeStartValue, startValue)
 }

+func TestAddMut(t *testing.T) {


Since Add is supposed to call AddMut, can you please do a short test like this instead of duplicating test cases?

p0mvn · 2022-12-19T15:26:11Z

osmomath/decimal_test.go

+	}
+}
+
+func TestQuoMut(t *testing.T) {


Same for this test case

p0mvn

LGTM

ValarDragon

Awesome!

* mut add * test add mut * quo mut * test quo mut/ remove want from test struct * refactor exp * change mutatives code * change * not allocaing * exp change to quomut * remove file * refactor quo * refactor ad * refactor tests (cherry picked from commit ca6ccbd) # Conflicts: # osmomath/exp2.go

* osmomath: `AddMut` and `QuoMut` (#3779) * mut add * test add mut * quo mut * test quo mut/ remove want from test struct * refactor exp * change mutatives code * change * not allocaing * exp change to quomut * remove file * refactor quo * refactor ad * refactor tests (cherry picked from commit ca6ccbd) # Conflicts: # osmomath/exp2.go * Delete exp2.go Co-authored-by: Ruslan Akhtariev <[email protected]> Co-authored-by: Dev Ojha <[email protected]>

* mut add * test add mut * quo mut * test quo mut/ remove want from test struct * refactor exp * change mutatives code * change * not allocaing * exp change to quomut * remove file * refactor quo * refactor ad * refactor tests

…14 (#3925) * Upgrade IBC to v4.2.0 (#3838) * initial changes to migrate to ibc v4 * added checksum to proposal * begin and end block are now being called inside nextBlock * added changelog * linked pr on changelog * remove local replace * using error acks from osmoutils * osmoutils tagged * go sum * added checksum * feat(x/twap): modify cli to add geometric option (#3812) * feat(x/twap): geometric twap code gen query boilerplate * revert cli change * query gen * wire up API * test * fix * fixes * cli * lint * refactor via flag * refactor * refactor * fixes * lint * add arithmetic twap alias * Make wasm hooks importable (#3850) * moved ibc-hooks to its own go.mod * updated ibc hooks version * go sum * add ics23 patch into x/ibc-hooks * Fix wasm import version conflict * Update x/ibc-hooks to osmoutils v0.0.2 * Update versions Co-authored-by: Dev Ojha <[email protected]> * refactor(x/twap): handle spot price error case in the context of geometric twap (#3845) * refactor(x/twap): handle spot price error case * supporting test cases * table-driven log tests * test(x/twap): add randomized geometric twap test on a balancer pool (#3844) * test(x/twap): add randomized test with a balancer pool * comments * multiplicative tolerance, fewer retries and larger initial supply range * Basic geometric twap e2e test (#3835) * feat(x/twap): geometric twap code gen query boilerplate * revert cli change * query gen * wire up API * test * fix * fixes * add geometric queries * create pool.json * add test * resolve conflict * fix: swap uosmo in * fix problem with wallet creation * updates * simplify and add comments * Update tests/e2e/e2e_test.go * Update tests/e2e/e2e_test.go * Update tests/e2e/configurer/chain/queries.go Co-authored-by: Adam Tucker <[email protected]> * Update tests/e2e/configurer/chain/queries.go Co-authored-by: Adam Tucker <[email protected]> * Update tests/e2e/e2e_test.go Co-authored-by: Adam Tucker <[email protected]> * Update tests/e2e/e2e_test.go Co-authored-by: Adam Tucker <[email protected]> * Update tests/e2e/e2e_test.go Co-authored-by: Adam Tucker <[email protected]> * Update tests/e2e/e2e_test.go Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Adam Tucker <[email protected]> * feat(x/twap): whitelist GeometricTwap and GeometricTwapToNow (#3852) * feat(x/twap): GeometricTwap and GeometricTwapToNow queries added to Stargate whitelist * update docs * fix(scripts): proto gen for osmoutils (#3854) * fix(scripts): proto gen for osmoutils * Update scripts/protocgen.sh * fix(scripts): proto gen osmoutils path (#3859) * added packet timeouts to wasm hooks (#3862) * add negative to cli (#3888) * Making osmoutils compile on chains that don't use our SDK fork (#3899) * making osmoutils compile on chains that don't use osmosis' fork of the cosmos sdk * updated imports for e2e tests * go fumpt * updated version everywhere * added changelog entry * remove deprecation from arithmetic & geometric twap to now query (#3917) * Add types & boilerplate for the Downtime detector module (#3609) Sub-component of #3603 Adds types for the thin module intended for downtime detection - Add downtime detection module types No tests added - Does this pull request introduce a new feature or user-facing behavior changes? somewhat - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? In its spec * Add downtime detector module (#3688) * WIP * Switch to enum * Remove params query * Add query * Add wiring, add import/export test * Start begin block test * Finish keeper tests * Add CLI * Wire downtime detector CLI + queries * more module wiring * add types test * Fix state alteration test * Fix superfluid test * Add stargate whitelist support * Apply code comment * Rename folder * Add requested godoc * Update x/downtime-detector/genesis.go Co-authored-by: Adam Tucker <[email protected]> * Apply adam suggestion for having a `-` * move genesis test to own file Co-authored-by: Adam Tucker <[email protected]> * Initial by hand fixes * feat(osmomath): Exp2 function (#3708) * feat(osmomath): exp2 function * export exp2 * changelog * refactor ErrTolerance to use Dec instead of Int for additive tolerance * Update osmomath/exp2.go * Update osmomath/exp2.go * Update osmomath/exp2.go * Update osmomath/exp2_test.go * Update osmomath/exp2_test.go * do bit shift instead of multiplication * godoc about error bounds * comment about bit shift equivalency * merge conflict * improve godoc * typo * remove TODOs - confirmed obsolete * Runge's phenomenon comment * [x/TWAP] Expose a geometric TWAP API (#3529) * refactored twap api.go for geometric TWAP * added barebon docs * romans feedback * new * fix * nichola feedback * final roman comments * fix twap by hand * change to gamm * fix balancer test * bump to v14 upgrade * e2e fix * add remaining diff from main to ibc-rate-limit * update contracts test * osmomath: `AddMut` and `QuoMut` (#3779) * mut add * test add mut * quo mut * test quo mut/ remove want from test struct * refactor exp * change mutatives code * change * not allocaing * exp change to quomut * remove file * refactor quo * refactor ad * refactor tests * Modify CHANGELOG * Whitelist EstimateSwapExactAmountOut (#3693) * whitelist EstimateSwapExactAmountOut * doc: changelog * updated rate limit contract * Fix rust checks (#3576) * added cargo.lock * added Cargo.lock as an artifact * added new bytecode with lock file Co-authored-by: Nicolas Lara <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Supanat <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: Ruslan Akhtariev <[email protected]> Co-authored-by: mattverse <[email protected]> Co-authored-by: ByeongSu Hong <[email protected]>

pysel added 5 commits December 17, 2022 10:56

mut add

28ac3a7

test add mut

e0e2601

quo mut

4978cbe

test quo mut/ remove want from test struct

2870114

refactor exp

2faea41

pysel added 2 commits December 17, 2022 19:48

change mutatives code

0993272

change

5fec9f4

p0mvn reviewed Dec 17, 2022

View reviewed changes

pysel added 2 commits December 18, 2022 09:04

not allocaing

0a20620

exp change to quomut

0b22fd0

pysel requested a review from p0mvn December 18, 2022 09:22

pysel added the F: geometric-twap label Dec 18, 2022

p0mvn requested changes Dec 19, 2022

View reviewed changes

pysel added 4 commits December 20, 2022 11:59

remove file

8be5795

refactor quo

f280099

refactor ad

8b11ef6

refactor tests

336e7b6

pysel requested a review from p0mvn December 21, 2022 16:17

p0mvn approved these changes Dec 21, 2022

View reviewed changes

ValarDragon approved these changes Dec 22, 2022

View reviewed changes

ValarDragon merged commit ca6ccbd into main Dec 22, 2022

ValarDragon deleted the ruslan/mutative_bdec branch December 22, 2022 04:16

mergify bot mentioned this pull request Dec 22, 2022

osmomath: AddMut and QuoMut (backport #3779) #3826

Merged

czarcas7ic mentioned this pull request Jan 5, 2023

chore: osmoutils, twap, downtime-detector, ibc-hooks cherry-pick to v14 #3925

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

osmomath: `AddMut` and `QuoMut` #3779

osmomath: `AddMut` and `QuoMut` #3779

pysel commented Dec 17, 2022 •

edited

Loading

ValarDragon commented Dec 17, 2022

pysel commented Dec 17, 2022

p0mvn Dec 17, 2022

p0mvn Dec 19, 2022

p0mvn Dec 19, 2022

p0mvn Dec 19, 2022

p0mvn Dec 19, 2022

p0mvn left a comment

ValarDragon left a comment

osmomath: AddMut and QuoMut #3779

osmomath: AddMut and QuoMut #3779

Conversation

pysel commented Dec 17, 2022 • edited Loading

What is the purpose of the change

ValarDragon commented Dec 17, 2022

pysel commented Dec 17, 2022

p0mvn Dec 17, 2022

Choose a reason for hiding this comment

p0mvn Dec 19, 2022

Choose a reason for hiding this comment

p0mvn Dec 19, 2022

Choose a reason for hiding this comment

p0mvn Dec 19, 2022

Choose a reason for hiding this comment

p0mvn Dec 19, 2022

Choose a reason for hiding this comment

p0mvn left a comment

Choose a reason for hiding this comment

ValarDragon left a comment

Choose a reason for hiding this comment

osmomath: `AddMut` and `QuoMut` #3779

osmomath: `AddMut` and `QuoMut` #3779

pysel commented Dec 17, 2022 •

edited

Loading