Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app/apptesting): PrepareBalancerPool helpers (simplifying swaprouter merge PR) #3772

Merged
merged 4 commits into from
Dec 17, 2022
Merged

refactor(app/apptesting): PrepareBalancerPool helpers (simplifying swaprouter merge PR) #3772

merged 4 commits into from
Dec 17, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Dec 16, 2022

Closes: #XXX

What is the purpose of the change

#3764 needs PrepareBalancerPool helper that takes coins and pool params.

This PR introduces these helpers and slightly cleans them up.

  • Introduced PrapareCustomBalancerPool that takes pool assets and pool params
  • Introduced PrepareCustomBalancerPoolFromCoins that takes coins and pool params. Each coin is converted to asset with a weight of 1
  • Removed PrepareBalancerPoolWithPoolAssets that takes pool assets only. There was only one use case. Replaced with `PrepareCustomBalancerPool instead
  • Reused all existing helpers where applicable to reduce code duplication

For example, PrepareBalancerPoolWithPoolAssets was

@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Dec 16, 2022
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:x/gamm Changes, features and bugs related to the gamm module. labels Dec 16, 2022
@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Dec 16, 2022
@p0mvn p0mvn marked this pull request as ready for review December 16, 2022 21:27
czarcas7ic
czarcas7ic approved these changes Dec 17, 2022
View reviewed changes
app/apptesting/gamm.go Show resolved Hide resolved
@p0mvn p0mvn merged commit 6206709 into main Dec 17, 2022
@p0mvn p0mvn deleted the roman/refactor-pool-creation-helpers branch December 17, 2022 21:45
mergify bot pushed a commit that referenced this pull request Dec 17, 2022
@p0mvn @mergify
refactor(app/apptesting): PrepareBalancerPool helpers (simplifying sw…
71e6479 
…aprouter merge PR) (#3772)

* refactor(app/apptesting): PrepareBalancerPool helpers

* improve godoc

* merge conflict

(cherry picked from commit 6206709)

# Conflicts:
#	app/apptesting/gamm.go
@mergify mergify bot mentioned this pull request Dec 17, 2022
Merged
p0mvn added a commit that referenced this pull request Dec 17, 2022
@p0mvn
refactor(app/apptesting): PrepareBalancerPool helpers (simplifying sw…
09d03a5 
…aprouter merge PR) (backport #3772)
p0mvn added a commit that referenced this pull request Dec 19, 2022
@mergify @p0mvn
refactor(app/apptesting): PrepareBalancerPool helpers (simplifying sw…
7dd1747 
…aprouter merge PR) (backport #3772) (#3781)

Co-authored-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch C:app-wiring Changes to the app folder C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board V:state/compatible/backport State machine compatible PR, should be backported
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic