refactor(wasmbindings): remove gamm and twap bindings #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
requested review from
ValarDragon,
czarcas7ic,
nicolaslara and
mattverse
ValarDragon
reviewed
Dec 16, 2022
| @@ -369,7 +369,6 @@ func (appKeepers *AppKeepers) InitNormalKeepers( | |||
| // if we want to allow any custom callbacks | |||
| supportedFeatures := "iterator,staking,stargate,osmosis,cosmwasm_1_1" | |||
|
|
|||
| wasmOpts = append(owasm.RegisterCustomPlugins(appKeepers.GAMMKeeper, appKeepers.BankKeeper, appKeepers.TwapKeeper, appKeepers.TokenFactoryKeeper), wasmOpts...) | |||
There was a problem hiding this comment.
bank definitely still needs to be there. TokenFactory is moving to general bindings as well, so I think we should keep that for now.
ACK for gamm + twap
p0mvn
changed the title
p0mvn
force-pushed
the
roman/remove-bindings
branch
from
fefdd83 to
2d8ff60
Compare
p0mvn
force-pushed
the
roman/remove-bindings
branch
from
2d8ff60 to
7096ecf
Compare
|
Planning to merge. No one has gotten back to me about using these on Telegram or Discord |
czarcas7ic
approved these changes
Dec 19, 2022
|
The only concern raised by the integrators is having the following queries whitelisted: osmosis/wasmbinding/stargate_whitelist.go Lines 87 to 88 in a5bc607 As a result, this should be good to be merged |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Removing bindings gamm and twap. These have been causing additional overhead during refactors while not having production use cases.
In production, everyone should be using
osmosis-stdinstead.Bank and tokenfactory bindings have use cases outside of Osmosis so these are kept for now.
An announcement about removal is to be made post-merge.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes