-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make wasm hooks importable #3747
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we make a separate PR for just moving the test folder, and get that merged in first? |
Done: #3803 |
For reference, this is how to get the version string if we want to avoid the replaces:
|
github-actions
bot
added
C:CLI
C:simulator
Edits simulator or simulations
C:x/epochs
C:x/incentives
C:x/lockup
C:x/mint
C:x/pool-incentives
C:x/superfluid
C:x/swaprouter
C:x/tokenfactory
C:x/txfees
labels
Dec 20, 2022
…tils_into_own_mod
There are too many conflicts here. Closing in favor of #3850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:app-wiring
Changes to the app folder
C:CLI
C:docs
Improvements or additions to documentation
C:simulator
Edits simulator or simulations
C:x/epochs
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/incentives
C:x/lockup
C:x/mint
C:x/pool-incentives
C:x/superfluid
C:x/swaprouter
C:x/tokenfactory
C:x/twap
Changes to the twap module
C:x/txfees
T:build
T:CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for experimenting with making wasm hooks importable.
I had to copy a few functions from osmoutils, which makes me think we should consider also making osmoutils its own package.
As an alternative, we could use workspaces (https://go.dev/blog/get-familiar-with-workspaces) to avoid having to deal with the scattered go.mod/sum files.