Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wasm hooks importable #3747

Closed
wants to merge 140 commits into from
Closed

Make wasm hooks importable #3747

wants to merge 140 commits into from

Conversation

nicolaslara
Copy link
Contributor

This is a draft PR for experimenting with making wasm hooks importable.

I had to copy a few functions from osmoutils, which makes me think we should consider also making osmoutils its own package.

As an alternative, we could use workspaces (https://go.dev/blog/get-familiar-with-workspaces) to avoid having to deal with the scattered go.mod/sum files.

@ValarDragon
Copy link
Member

Can we make a separate PR for just moving the test folder, and get that merged in first?

@nicolaslara
Copy link
Contributor Author

Can we make a separate PR for just moving the test folder, and get that merged in first?

Done: #3803

@nicolaslara
Copy link
Contributor Author

For reference, this is how to get the version string if we want to avoid the replaces:

TZ=UTC git --no-pager show \
  --quiet \
  --abbrev=12 \
  --date='format-local:%Y%m%d%H%M%S' \
  --format="%cd-%h"

@nicolaslara
Copy link
Contributor Author

There are too many conflicts here. Closing in favor of #3850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:CLI C:docs Improvements or additions to documentation C:simulator Edits simulator or simulations C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/mint C:x/pool-incentives C:x/superfluid C:x/swaprouter C:x/tokenfactory C:x/twap Changes to the twap module C:x/txfees T:build T:CI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants