Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove settings that configure state sync #3522

Closed
wants to merge 1 commit into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Nov 25, 2022

closes: #3517

Use default state sync configuration

This PR removes settings that should no longer need to be set, and maybe never should have been set. Specifically, this PR relies more heavily on upstream defaults:

  • using the default state sync trust period, instead of 112 hours
  • taking a snapshot every 1000 blocks, instead of 1500 (iirc)
  • disabling serving state sync snapshots by default

Testing and Verifying

This change added tests and can be verified as follows:

  • Manually verified the change by running a node with these settings, then state syncing to my desktop against it.

Script to reproduce the findings is here:

Working:
https://github.com/osmosis-labs/osmosis/blob/faddat/working-state-sync-example/scripts/statesync-resolution.bash

Not Working:
https://github.com/osmosis-labs/osmosis/blob/faddat/working-state-sync-example/scripts/statesync.bash

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no) yes:
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no) yes
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@faddat faddat marked this pull request as ready for review November 26, 2022 00:50
@faddat faddat requested a review from a team November 26, 2022 00:50
@faddat faddat marked this pull request as draft November 26, 2022 01:07
@faddat faddat changed the base branch from v12.x to main November 26, 2022 01:07
@faddat faddat changed the base branch from main to v12.x November 26, 2022 01:08
@faddat
Copy link
Member Author

faddat commented Nov 26, 2022

closing this since it didn't target the correct branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant