Add Pool Type Query #2832
Merged
Add Pool Type Query #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
reviewed
Sep 25, 2022
x/gamm/keeper/grpc_query.go
Outdated
|
|
||
| switch pool := pool.(type) { | ||
| case *balancer.Pool: | ||
| return &types.QueryPoolTypeResponse{PoolType: "Balancer"}, nil |
There was a problem hiding this comment.
We should have this be exposed as a method on the pool interface, right?
Or at least, lets make a go API for keeper.PoolType(ctx, poolId) (string, error), to have it in a more discoverable point
There was a problem hiding this comment.
Changed to having go API, I would prefer having further discussion in adding pool type to PoolI, I'd like to go ahead and open an issue for this for further discussion for this if you agree!
ValarDragon
approved these changes
Sep 26, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
Closes: #2739 ## What is the purpose of the change Adds pool type query to query the type of pool. The query would return a string of the type of pool in a string, depending on the type of pool, would return an error otherwise. ## Brief Changelog - Add pool type query ## Testing and Verifying Added new test cases ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`?yes - How is the feature or change documented? (not applicable / specification (`x/<module>/spec/`) / [Osmosis docs repo](https://github.com/osmosis-labs/docs) / not documented) (cherry picked from commit ae6a366) # Conflicts: # CHANGELOG.md
pysel
pushed a commit
to pysel/osmosis
that referenced
this pull request
Sep 28, 2022
Closes: osmosis-labs#2739 ## What is the purpose of the change Adds pool type query to query the type of pool. The query would return a string of the type of pool in a string, depending on the type of pool, would return an error otherwise. ## Brief Changelog - Add pool type query ## Testing and Verifying Added new test cases ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`?yes - How is the feature or change documented? (not applicable / specification (`x/<module>/spec/`) / [Osmosis docs repo](https://github.com/osmosis-labs/docs) / not documented)
mattverse
added a commit
that referenced
this pull request
Sep 30, 2022
* Add Pool Type Query (#2832) Closes: #2739 ## What is the purpose of the change Adds pool type query to query the type of pool. The query would return a string of the type of pool in a string, depending on the type of pool, would return an error otherwise. ## Brief Changelog - Add pool type query ## Testing and Verifying Added new test cases ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`?yes - How is the feature or change documented? (not applicable / specification (`x/<module>/spec/`) / [Osmosis docs repo](https://github.com/osmosis-labs/docs) / not documented) (cherry picked from commit ae6a366) # Conflicts: # CHANGELOG.md * fix merge conflict Co-authored-by: Matt, Park <[email protected]> Co-authored-by: mattverse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2739
What is the purpose of the change
Adds pool type query to query the type of pool. The query would return a string of the type of pool in a string, depending on the type of pool, would return an error otherwise.
Brief Changelog
Testing and Verifying
Added new test cases
Documentation and Release Note
Unreleasedsection inCHANGELOG.md?yesx/<module>/spec/) / Osmosis docs repo / not documented)