-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gamm): improve error handling and messages when parsing pool assets #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
refactor(gamm): improve error handling and mesages when parsing pool…
refactor(gamm): improve error handling and mesages when parsing pool assets
Sep 20, 2022
github-actions
bot
added
the
C:x/gamm
Changes, features and bugs related to the gamm module.
label
Sep 20, 2022
p0mvn
changed the title
refactor(gamm): improve error handling and mesages when parsing pool assets
refactor(gamm): improve error handling and messages when parsing pool assets
Sep 20, 2022
ValarDragon
approved these changes
Sep 28, 2022
AlpinYukseloglu
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ValarDragon
added
V:state/compatible/backport
State machine compatible PR, should be backported
A:automerge
labels
Sep 29, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
… assets (#2804) Closes: #XXX ## What is the purpose of the change The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages. This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit f024498) # Conflicts: # CHANGELOG.md
p0mvn
added a commit
that referenced
this pull request
Oct 1, 2022
… assets (backport #2804) (#2901) * resolve conflicts * Update CHANGELOG.md Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
A:backport/v12.x
backport patches to v12.x branch
C:docs
Improvements or additions to documentation
C:x/gamm
Changes, features and bugs related to the gamm module.
V:state/compatible/backport
State machine compatible PR, should be backported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages.
This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes