-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation setup improvements #2588
Conversation
// in case we have to end early, don't os.Exit so that we can run cleanup code. | ||
// TODO: Understand exit pattern, this is so screwed up. Then delete ^ | ||
|
||
legacyInvariantPeriod := uint(10) // TODO: Make a better answer of what to do here, at minimum put into config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This todo should just get handled with more property check work, and being able to set this to 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! ACK everything except for the pubsub stuff, which I know is still getting fleshed out 🚀
What is the purpose of the change
A long standing issue of the simulator is how complex / verbose its setup code is, for very little reason.
I was working on adding property checks, and got derailed in trying to simplify the setup code & be able to use the simulation manager within the executor.
One spin off is: #2587
This has some of the basic property check struct definitions in here, so that these aren't living in stale branches. Its not in use with this.
Overarching instantiation changes:
AppConstructor
rather than the app itselfBrief Changelog
Testing and Verifying
Simulator still works
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes