Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/superfluid): improve error handling for AddNewSuperfluidAsset #2473

Merged
merged 2 commits into from
Aug 21, 2022
Merged

refactor(x/superfluid): improve error handling for AddNewSuperfluidAsset #2473

merged 2 commits into from
Aug 21, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 20, 2022

Closes: #XXX

What is the purpose of the change

Drive-by changes to improve error handling when adding superfluid assets.

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:x/superfluid labels Aug 20, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Aug 20, 2022
@p0mvn p0mvn marked this pull request as ready for review August 21, 2022 00:21
@p0mvn p0mvn requested a review from a team August 21, 2022 00:21
@ValarDragon ValarDragon merged commit 2279d80 into main Aug 21, 2022
@ValarDragon ValarDragon deleted the roman/superfluid-asset branch August 21, 2022 18:51
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:x/superfluid
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon