fix: swagger docs & swagger generation #2233 #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Aug 2, 2022
The current doc is absolutely outdated. A lot of missing queries paired with not working queries: |
|
Thanks for doing this @ctrl-Felix! It was for sure needed for those using swagger endpoint 😄 |
czarcas7ic
approved these changes
Aug 2, 2022
|
Thanks for fixing this! Let me make an issue to revisit if theres a better flow we can have as well This makes sense to backport to v11 right? |
p0mvn
approved these changes
Aug 3, 2022
I think that makes sense |
p0mvn
pushed a commit
that referenced
this pull request
Aug 3, 2022
(cherry picked from commit 1592bb8) Co-authored-by: Felix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2233
What is the purpose of the change
Fix the swagger API documentation
Brief Changelog
docs/config.jsonand add all missing protobuf files/dirsmake docsto not interfere with/docsTesting and Verifying
Run
make docsDocumentation and Release Note
I am not sure about that