Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check coins are positive in lockup ValidateBasic #2180

Merged
merged 3 commits into from
Jul 22, 2022
Merged

fix: check coins are positive in lockup ValidateBasic #2180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
344de9b
add check to lockup validate basic
czarcas7ic Jul 21, 2022
1a9d0bc
add table driven test for ValidateBasic
czarcas7ic Jul 21, 2022
72477cc
Update msgs_test.go
czarcas7ic Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x/lockup/types/msgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ func (m MsgLockTokens) ValidateBasic() error {
return fmt.Errorf("lockups can only have one denom per lock ID, got %v", m.Coins)
}

if !m.Coins.IsAllPositive() {
czarcas7ic marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("cannot lock up a zero or negative amount")
}

return nil
}

Expand Down