-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gamm keeper delete obsolete files #2160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry should be changed to breaking changes, other than that LGTM!
@@ -21,6 +21,6 @@ option go_package = "github.com/osmosis-labs/osmosis/v10/x/gamm/types"; | |||
message GenesisState { | |||
repeated google.protobuf.Any pools = 1 | |||
[ (cosmos_proto.accepts_interface) = "PoolI" ]; | |||
uint64 next_pool_number = 2; | |||
uint64 next_pool_id = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU, when you break proto like this, you technically have to bump the package version. i.e. osmosis.gamm.v2beta1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So field name changes like this break clients and json serialization, but I think its fine to do so for genesis
cc @daniel-farina @czarcas7ic if field renames / genesis file breaks like this end up being problematic for integrators
Can we separate out the deletes here from the genesis field rename Can easily get all the file deletes merged |
Actually I'll just commit undoing that proto field rename, and we can re-open a new issue for talking about genesis breaks |
* remove vestigial test files * move params into keeper.go * move stableswap scaling factor * change pool number to pool id where applicable * further pool number changes * make proto level pool number changes * add changelog entry * remove completed TODO comment * undo proto change Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit 8cac090) # Conflicts: # CHANGELOG.md # go.mod # x/gamm/keeper/genesis.go # x/gamm/keeper/grpc_query.go # x/gamm/keeper/params.go # x/gamm/keeper/pool.go # x/gamm/keeper/pool_service.go # x/gamm/pool-models/stableswap/pool.go # x/gamm/simulation/sim_msgs.go
Closes: #2155
What is the purpose of the change
Cleanup of
x/gamm/keeper
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)