chore: x/mint docs and clean up, excluding mint keeper (backport #1857) #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
force-pushed
the
roman/mint-backport-1
branch
from
1033ee6 to
febf8d8
Compare
stackman27
reviewed
Jul 18, 2022
stackman27
reviewed
Jul 18, 2022
stackman27
reviewed
Jul 18, 2022
stackman27
reviewed
Jul 18, 2022
stackman27
reviewed
Jul 18, 2022
|
@stackman27 thanks for the suggestions. I think all of these are valid and we should integrate them with a new PR to Applying them here does not make sense since this is a backport. They would all get lost in that case |
yessir i will do so |
p0mvn
commented
Jul 18, 2022
| [ (gogoproto.moretags) = "yaml:\"halven_started_epoch\"" ]; | ||
| // reduction_started_epoch is the first epoch in which the reduction of mint | ||
| // begins. | ||
| int64 reduction_started_epoch = 3 |
There was a problem hiding this comment.
This might be state-braking due to this proto change. Is this not backport acceptable?
|
let's just close this since this is proto breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Manual backport of #1857.
(Mergify would not open another PR for this, the original was closed due to protos not being generated on
v10.x)This does not contain any additional changes.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no