lint: enable unused in golangci-lint #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
p0mvn
commented
Jul 1, 2022
| @@ -95,5 +95,12 @@ issues: | |||
| - path: client/docs | |||
| linters: | |||
| - all | |||
| - path: x/gamm/pool-models/stableswap | |||
| linters: | |||
| # Stableswap is in development. | |||
There was a problem hiding this comment.
TODO: add issue reminding to re-enable this
p0mvn
commented
Jul 1, 2022
ValarDragon
reviewed
Jul 1, 2022
x/gamm/keeper/msg_server.go
Outdated
| sdk.NewAttribute(sdk.AttributeKeySender, msg.Sender), | ||
| ), | ||
| }) | ||
| server.keeper.createAddLiquidityEvent(ctx, sender, msg.PoolId, addedLiquidity) |
There was a problem hiding this comment.
Lets please separate out lint PRs from functionality changes / more detailed refactors like this
p0mvn
commented
Jul 1, 2022
| @@ -61,6 +61,7 @@ func NewKeeper(cdc codec.BinaryCodec, storeKey sdk.StoreKey, paramSpace paramtyp | |||
| } | |||
| } | |||
|
|
|||
| // nolint: unused | |||
| func (k *Keeper) createSwapEvent(ctx sdk.Context, sender sdk.AccAddress, poolId uint64, input sdk.Coins, output sdk.Coins) { | |||
There was a problem hiding this comment.
TODO: re-enable missing events
5 tasks
|
Strong support of this :) |
ValarDragon
reviewed
Jul 4, 2022
Comment on lines
-91
to
-92
| accountKeeper stakingtypes.AccountKeeper | ||
| bankKeeper stakingtypes.BankKeeper |
There was a problem hiding this comment.
Ah good catch that this was caught
ValarDragon
approved these changes
Jul 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #1897
What is the purpose of the change
We would like to improve the quality of our codebase by trying out components of the staticcheck linter.
This change introduced
unused- 1st of the 4 componentsAlthough, we added
deadcodelinter in #1934,unusedseems to be detecting more unused logic.In addition to removing the unused code, the following was done:
unusedanddeadcodeforx/gamm/pool-models/stableswapsince it is currently in developmentDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? no