Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/lock: Fix ExtendLockup API #1937

Merged
merged 3 commits into from
Jul 1, 2022
Merged

x/lock: Fix ExtendLockup API #1937

merged 3 commits into from
Jul 1, 2022

Conversation

mattverse
Copy link
Member

Sub-component of: #1838

What is the purpose of the change

The current ExtendLockup API directly takes in the lock object as a pointer as its parameter. This PR changes this existing API to take in lock ID to improve safety for this API

Brief Changelog

ImproveExtendLockup API safety.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not documented

@mattverse mattverse requested a review from a team July 1, 2022 07:53
@mattverse mattverse mentioned this pull request Jul 1, 2022
Closed
7 tasks
alexanderbez
alexanderbez approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a changelog for this IMO

ValarDragon
ValarDragon reviewed Jul 1, 2022
View reviewed changes
x/lockup/keeper/lock.go Outdated Show resolved Hide resolved
ValarDragon
ValarDragon approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets add a Go API changelog entry

@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 1, 2022
@ValarDragon ValarDragon merged commit 99304f2 into main Jul 1, 2022
@ValarDragon ValarDragon deleted the mattverse/change-extendlock-api branch July 1, 2022 20:11
@mattverse
Copy link
Member Author

thanks for adding the chnage log and merging!

@mattverse mattverse added the A:backport/v10.x backport patches to v10.x branch label Jul 12, 2022
mergify bot pushed a commit that referenced this pull request Jul 12, 2022
@mattverse @mergify
x/lock: Fix ExtendLockup API (#1937)
9b06110 
* Fix extendlock api

* Apply suggestions from code review

* Add changelog

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
(cherry picked from commit 99304f2)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 12, 2022
Merged
mattverse added a commit that referenced this pull request Jul 12, 2022
@mergify @mattverse
x/lock: Fix ExtendLockup API (backport #1937) (#2030)
bd32316 
* x/lock: Fix `ExtendLockup` API  (#1937)

* Fix extendlock api

* Apply suggestions from code review

* Add changelog

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
(cherry picked from commit 99304f2)

# Conflicts:
#	CHANGELOG.md

* Fix merge conflict: changelog

Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: mattverse <[email protected]>
ValarDragon added a commit that referenced this pull request Aug 1, 2022
@ValarDragon
Revert "x/lock: Fix ExtendLockup API (backport #1937) (#2030)"
54f8d89 
This reverts commit bd32316.
ValarDragon added a commit that referenced this pull request Aug 3, 2022
@ValarDragon
Fix v10.x state incompatability (#2268)
9e178a6 
* Revert "x/lock: Fix `ExtendLockup` API  (backport #1937) (#2030)"

This reverts commit bd32316.

* Revert "Refactor `lock` method (backport #1936) (#2029)"

This reverts commit d733f64.

* Update changelog

* Update changelog
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
A:backport/v10.x backport patches to v10.x branch C:docs Improvements or additions to documentation C:x/lockup
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattverse @alexanderbez @ValarDragon @p0mvn