Making CI for testing generated proto correctness #1892
Conversation
|
|
||
| - name: "Check protobuf generated code" | ||
| run: | | ||
| set -euo pipefail |
There was a problem hiding this comment.
We should just put this all in a script under contrib/.
|
Looking into the go.mod issue! |
| with: | ||
| password: ${{ secrets.ADD_TO_PROJECT_PAT }} |
There was a problem hiding this comment.
Why is this needed?
This also should be a different access token, lets set that up differently
There was a problem hiding this comment.
This most likely isn't - sorry I'm just testing out some stuff to implement the feedback above
|
Not sure what you mean by go.mod and go.sum @mattverse ? We should have in another PR, make a second job that checks go mod & go sum correctness |
|
Oh I was saying that this "shouldn't" include |
|
Seems like the CI is breaking for this PR? Is that an expected behaviour resulting from this PR not being merged yet? |
|
Unexpected behavior, I detailed this a bit in slack if you wouldn’t mind
taking a look :)
…On Fri, Jul 1, 2022 at 1:42 AM Matt, Park ***@***.***> wrote:
Seems like the CI is breaking for this PR? Is that an expected behaviour
resulting from this PR not being merged yet?
—
Reply to this email directly, view it on GitHub
<#1892 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASH4FPUJUXYZ4WTUY2OUZZDVR2AMDANCNFSM52DR6B4A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Passing all tests, ready for merge |
| branches: | ||
| - main |
(cherry picked from commit 0956d89) # Conflicts: # chain.schema.json
…2074) * Making CI for testing generated proto correctness (#1892) (cherry picked from commit 0956d89) # Conflicts: # chain.schema.json * Fix proto Co-authored-by: Xiangan He <[email protected]> Co-authored-by: Dev Ojha <[email protected]>
Closes: #1256
What is the purpose of the change
This CI will help us catch whenever make proto-all wasn't ran via a job that does make proto-all,and returns an error if there is a diff betrween the post make proto-all output, and any .proto or .pb.go file, as well as tool-chain related errors.
Brief Changelog
Added job in check-generated.yml that fails if make proto-all wasn't done before PR
Testing and Verifying
(Please pick one of the following options)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)