-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incentives query filtering #1759
Merged
ValarDragon
merged 10 commits into
osmosis-labs:main
from
notional-labs:issue-fix-filtering
Jun 15, 2022
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f5292cd
Merge pull request #3 from osmosis-labs/main
hieuvubk 62d4d47
fix filtering logic
hieuvubk 66ef1c6
add test
hieuvubk d6811c0
format
hieuvubk ba75477
Merge pull request #32 from hieuvubk/issue-pagination
hieuvubk 40a5c38
fix: append element in loop
hieuvubk b8539ed
use range
hieuvubk 7d81622
optimize code, make filtering into a separate function
hieuvubk bc69184
format
hieuvubk 9b9a0cf
add to changelog
hieuvubk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -63,19 +63,7 @@ func (q Querier) Gauges(goCtx context.Context, req *types.GaugesRequest) (*types | |||||
} | ||||||
|
||||||
ctx := sdk.UnwrapSDKContext(goCtx) | ||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
valStore := prefix.NewStore(store, types.KeyPrefixGauges) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(valStore, req.Pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
newGauges, err := q.getGaugeFromIDJsonBytes(ctx, value) | ||||||
if err != nil { | ||||||
panic(err) | ||||||
} | ||||||
gauges = append(gauges, newGauges...) | ||||||
|
||||||
return true, nil | ||||||
}) | ||||||
pageRes, gauges, err := q.filterByPrefixAndDenom(ctx, types.KeyPrefixGauges, "", req.Pagination) | ||||||
if err != nil { | ||||||
return nil, status.Error(codes.Internal, err.Error()) | ||||||
} | ||||||
|
@@ -90,19 +78,8 @@ func (q Querier) ActiveGauges(goCtx context.Context, req *types.ActiveGaugesRequ | |||||
} | ||||||
|
||||||
ctx := sdk.UnwrapSDKContext(goCtx) | ||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
valStore := prefix.NewStore(store, types.KeyPrefixActiveGauges) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(valStore, req.Pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
newGauges, err := q.getGaugeFromIDJsonBytes(ctx, value) | ||||||
if err != nil { | ||||||
panic(err) | ||||||
} | ||||||
gauges = append(gauges, newGauges...) | ||||||
|
||||||
return true, nil | ||||||
}) | ||||||
pageRes, gauges, err := q.filterByPrefixAndDenom(ctx, types.KeyPrefixActiveGauges, "", req.Pagination) | ||||||
if err != nil { | ||||||
return nil, status.Error(codes.Internal, err.Error()) | ||||||
} | ||||||
|
@@ -117,19 +94,7 @@ func (q Querier) ActiveGaugesPerDenom(goCtx context.Context, req *types.ActiveGa | |||||
} | ||||||
|
||||||
ctx := sdk.UnwrapSDKContext(goCtx) | ||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
valStore := prefix.NewStore(store, types.KeyPrefixActiveGauges) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(valStore, req.Pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
activeGauges := q.Keeper.GetActiveGauges(ctx) | ||||||
for _, gauge := range activeGauges { | ||||||
if gauge.DistributeTo.Denom == req.Denom { | ||||||
gauges = append(gauges, gauge) | ||||||
} | ||||||
} | ||||||
return true, nil | ||||||
}) | ||||||
pageRes, gauges, err := q.filterByPrefixAndDenom(ctx, types.KeyPrefixActiveGauges, req.Denom, req.Pagination) | ||||||
if err != nil { | ||||||
return nil, status.Error(codes.Internal, err.Error()) | ||||||
} | ||||||
|
@@ -144,19 +109,8 @@ func (q Querier) UpcomingGauges(goCtx context.Context, req *types.UpcomingGauges | |||||
} | ||||||
|
||||||
ctx := sdk.UnwrapSDKContext(goCtx) | ||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
valStore := prefix.NewStore(store, types.KeyPrefixUpcomingGauges) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(valStore, req.Pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
newGauges, err := q.getGaugeFromIDJsonBytes(ctx, value) | ||||||
if err != nil { | ||||||
panic(err) | ||||||
} | ||||||
gauges = append(gauges, newGauges...) | ||||||
|
||||||
return true, nil | ||||||
}) | ||||||
pageRes, gauges, err := q.filterByPrefixAndDenom(ctx, types.KeyPrefixUpcomingGauges, "", req.Pagination) | ||||||
if err != nil { | ||||||
return nil, status.Error(codes.Internal, err.Error()) | ||||||
} | ||||||
|
@@ -174,19 +128,7 @@ func (q Querier) UpcomingGaugesPerDenom(goCtx context.Context, req *types.Upcomi | |||||
return nil, status.Error(codes.InvalidArgument, "invalid denom") | ||||||
} | ||||||
|
||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
prefixStore := prefix.NewStore(store, types.KeyPrefixUpcomingGauges) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(prefixStore, req.Pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
upcomingGauges := q.Keeper.GetUpcomingGauges(ctx) | ||||||
for _, gauge := range upcomingGauges { | ||||||
if gauge.DistributeTo.Denom == req.Denom { | ||||||
gauges = append(gauges, gauge) | ||||||
} | ||||||
} | ||||||
return true, nil | ||||||
}) | ||||||
pageRes, gauges, err := q.filterByPrefixAndDenom(ctx, types.KeyPrefixUpcomingGauges, req.Denom, req.Pagination) | ||||||
if err != nil { | ||||||
return nil, status.Error(codes.Internal, err.Error()) | ||||||
} | ||||||
|
@@ -253,3 +195,33 @@ func (q Querier) getGaugeFromIDJsonBytes(ctx sdk.Context, refValue []byte) ([]ty | |||||
|
||||||
return gauges, nil | ||||||
} | ||||||
|
||||||
// Filter gauges based on given prefix type and denom | ||||||
func (q Querier) filterByPrefixAndDenom(ctx sdk.Context, prefixType []byte, denom string, pagination *query.PageRequest) (*query.PageResponse, []types.Gauge, error) { | ||||||
gauges := []types.Gauge{} | ||||||
store := ctx.KVStore(q.Keeper.storeKey) | ||||||
valStore := prefix.NewStore(store, prefixType) | ||||||
|
||||||
pageRes, err := query.FilteredPaginate(valStore, pagination, func(key []byte, value []byte, accumulate bool) (bool, error) { | ||||||
// This may return multiple gauges at once if two gauges start at the same time. | ||||||
// For now this is treated as an edge case that is not of importance | ||||||
newGauges, err := q.getGaugeFromIDJsonBytes(ctx, value) | ||||||
if err != nil { | ||||||
panic(err) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
if accumulate { | ||||||
if denom != "" { | ||||||
for _, gauge := range newGauges { | ||||||
if gauge.DistributeTo.Denom != denom { | ||||||
return false, nil | ||||||
} | ||||||
gauges = append(gauges, gauge) | ||||||
} | ||||||
} else { | ||||||
gauges = append(gauges, newGauges...) | ||||||
} | ||||||
} | ||||||
return true, nil | ||||||
}) | ||||||
return pageRes, gauges, err | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.