Delete unused simulator code #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
ValarDragon
commented
Jun 5, 2022
| epochInfo := types.EpochInfo{ | ||
| Identifier: "monthly", | ||
| StartTime: time.Time{}, | ||
| Duration: time.Hour * 24 * 30, | ||
| CurrentEpoch: 0, | ||
| CurrentEpochStartTime: time.Time{}, | ||
| EpochCountingStarted: false, | ||
| } | ||
| epochInfo := types.NewGenesisEpochInfo("monthly", time.Hour*24*30) |
ValarDragon
commented
Jun 5, 2022
Comment on lines
24
to
+30
|
|
||
| require.Equal(t, genesis.Epochs[0].Identifier, "day") | ||
| require.Equal(t, genesis.Epochs[0].StartTime, chainStartTime) | ||
| require.Equal(t, genesis.Epochs[0].Duration, time.Hour*24) | ||
| require.Equal(t, genesis.Epochs[0].CurrentEpoch, int64(0)) | ||
| require.Equal(t, genesis.Epochs[0].CurrentEpochStartHeight, chainStartHeight) | ||
| require.Equal(t, genesis.Epochs[0].CurrentEpochStartTime, chainStartTime) | ||
| require.Equal(t, genesis.Epochs[0].EpochCountingStarted, false) | ||
| require.Equal(t, genesis.Epochs[1].Identifier, "week") | ||
| require.Equal(t, genesis.Epochs[1].StartTime, chainStartTime) | ||
| require.Equal(t, genesis.Epochs[1].Duration, time.Hour*24*7) | ||
| require.Equal(t, genesis.Epochs[1].CurrentEpoch, int64(0)) | ||
| require.Equal(t, genesis.Epochs[1].CurrentEpochStartHeight, chainStartHeight) | ||
| require.Equal(t, genesis.Epochs[1].CurrentEpochStartTime, chainStartTime) | ||
| require.Equal(t, genesis.Epochs[1].EpochCountingStarted, false) | ||
| expectedEpochs := types.DefaultGenesis().Epochs | ||
| for i := 0; i < len(expectedEpochs); i++ { | ||
| expectedEpochs[i].CurrentEpochStartHeight = chainStartHeight | ||
| expectedEpochs[i].CurrentEpochStartTime = chainStartTime | ||
| } | ||
| require.Equal(t, expectedEpochs, genesis.Epochs) |
p0mvn
approved these changes
Jun 6, 2022
vuong177
added a commit
that referenced
this pull request
Jun 6, 2022
* refactor wasmbing * refactor in wasmbinding/test * change wasmbinding file path in simapp test * README in wasmbinding * minor * remove Why Osmosis from README (#1690) * Fix make format (#1693) ## What is the purpose of the change Fixes `make format`, needed `mvdan.cc` added to tools directory. ## Brief Changelog * Add mvdan.cc/gofumpt to tools folder * Restrict it to only run on `app/ x/ ante/`, it has this annoying problem that it cannot run on the entire root folder because it reads the `.git` folder. It inherits the problem from `gofmt` that it cannot ignore a particular directory. ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? Should land into contributing.md once its here * Delete unused simulator code (#1671) * Delete unused simulator code * Add hourly epochs to the x/epochs DefaultGenesis * Add changelog * Delete the unused x/gamm/simulation folder * Fix epochs module tests for updated DefaultGenesis * update CHANGELOG * minor Co-authored-by: alpo <[email protected]> Co-authored-by: Dev Ojha <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Delete unused simulator code * Add hourly epochs to the x/epochs DefaultGenesis * Add changelog * Delete the unused x/gamm/simulation folder * Fix epochs module tests for updated DefaultGenesis (cherry picked from commit f21e29e) # Conflicts: # CHANGELOG.md # x/epochs/module.go # x/epochs/simulation/genesis.go # x/gamm/module.go # x/gamm/simulation/operations.go # x/mint/simulation/params_test.go
ValarDragon
added a commit
that referenced
this pull request
Jul 20, 2022
* Delete unused simulator code (#1671) * Delete unused simulator code * Add hourly epochs to the x/epochs DefaultGenesis * Add changelog * Delete the unused x/gamm/simulation folder * Fix epochs module tests for updated DefaultGenesis (cherry picked from commit f21e29e) # Conflicts: # CHANGELOG.md # x/epochs/module.go # x/epochs/simulation/genesis.go # x/gamm/module.go # x/gamm/simulation/operations.go # x/mint/simulation/params_test.go * fix conflicts and align backport with actual PR * fix changelog conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: alpo <[email protected]> Co-authored-by: alpo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove unused boilerplate / noise from our code, for modules that don't use the simulator, or left it in unused states.
This is a change that deletes 1% of the non-generated file code in the
x/package.Brief Changelog
AppModuleSimulationAPI for several modules'AppModule.x/epochsDefaultGenesisTesting and Verifying
make test-simstill passesDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? yes