x/tokenfactory: .proto files #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
- Coverage 19.82% 19.79% -0.04%
==========================================
Files 202 202
Lines 27685 27763 +78
==========================================
+ Hits 5489 5496 +7
- Misses 21175 21246 +71
Partials 1021 1021
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Apr 27, 2022
Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
reviewed
Apr 27, 2022
ValarDragon
approved these changes
Apr 27, 2022
alexanderbez
approved these changes
Apr 27, 2022
Comment on lines
+57
to
+70
| // // ===================== MsgForceTransfer | ||
| // message MsgForceTransfer { | ||
| // string sender = 1 [ (gogoproto.moretags) = "yaml:\"sender\"" ]; | ||
| // cosmos.base.v1beta1.Coin amount = 2 [ | ||
| // (gogoproto.moretags) = "yaml:\"amount\"", | ||
| // (gogoproto.nullable) = false | ||
| // ]; | ||
| // string transferFromAddress = 3 | ||
| // [ (gogoproto.moretags) = "yaml:\"transfer_from_address\"" ]; | ||
| // string transferToAddress = 4 | ||
| // [ (gogoproto.moretags) = "yaml:\"transfer_to_address\"" ]; | ||
| // } | ||
|
|
||
| // message MsgForceTransferResponse {} |
There was a problem hiding this comment.
Do we need this commented out?
There was a problem hiding this comment.
Wanted to deactivate this message for now, but we will eventually add it back in in the future
There was a problem hiding this comment.
Should we track this in an issue?
p0mvn
approved these changes
Apr 29, 2022
| (gogoproto.moretags) = "yaml:\"authority_metadata\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| } |
| } | ||
| message QueryDenomsFromCreatorResponse { | ||
| repeated string denoms = 1 [ (gogoproto.moretags) = "yaml:\"denoms\"" ]; | ||
| } |
Comment on lines
+57
to
+70
| // // ===================== MsgForceTransfer | ||
| // message MsgForceTransfer { | ||
| // string sender = 1 [ (gogoproto.moretags) = "yaml:\"sender\"" ]; | ||
| // cosmos.base.v1beta1.Coin amount = 2 [ | ||
| // (gogoproto.moretags) = "yaml:\"amount\"", | ||
| // (gogoproto.nullable) = false | ||
| // ]; | ||
| // string transferFromAddress = 3 | ||
| // [ (gogoproto.moretags) = "yaml:\"transfer_from_address\"" ]; | ||
| // string transferToAddress = 4 | ||
| // [ (gogoproto.moretags) = "yaml:\"transfer_to_address\"" ]; | ||
| // } | ||
|
|
||
| // message MsgForceTransferResponse {} |
There was a problem hiding this comment.
Should we track this in an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
*Add a description of the overall background and high level changes that this PR introduces *
This PR adds the proto files relevant for the tokenfactory module.
It contains the following Msg types for the module:
It contains the following queries:
It contains a commented out Msg type for "force transfers". Force transfers are disabled based on discussion in: #1029
Testing and Verifying
This change is only proto file additions without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)