Move forceprune logic into functions, make db open/closes all in a single scope #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
commented
Apr 22, 2022
Comment on lines
+136
to
+138
| opts := opt.Options{ | ||
| DisableSeeksCompaction: true, | ||
| } |
There was a problem hiding this comment.
I chose to duplicate this in each function, since its pretty unclear to me that longer term, these won't be different for every function
ValarDragon
added
the
A:backport/v7.x
Codecov Report
@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
- Coverage 19.81% 19.42% -0.40%
==========================================
Files 210 199 -11
Lines 27884 27455 -429
==========================================
- Hits 5525 5332 -193
+ Misses 21333 21133 -200
+ Partials 1026 990 -36 Continue to review full report at Codecov.
|
p0mvn
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Follow up PR to #1262, it shuffles the logic into functions, so each db opening and closing all happens in a single scope. (And therefore defer closes work as expected)
Beyond DB closing behavior, the logic should be identical
cc @moniya12
Brief change log
No logic change, just code structure updates to the forceprune command. Also updates variables names from snake case to camel case (matching the rest of the repo)
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no (not needed)