Remove claim module #1299
Closed
Remove claim module #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jlbit <[email protected]>
Co-authored-by: jlbit <[email protected]>
* refactor: ExitSwapExternAmountOut * better name for interface extension * implement types.PoolExitSwapExternAmountOutExtension * update changelog * interface assertion for PoolI in balancer pool * err check on extendedPool.ExitSwapExternAmountOut * ZeroDec() * comma in calcPoolInGivenSingleOut call * redundnet type in calcPoolInGivenSingleOut * comment for feeRatio * fix comment for calcPoolInGivenSingleOut and the converse * whitespace in ExitSwapExternAmountOut * fix changelog entry * godoc for PoolExitSwapExternAmountOutExtension * fmt * gofumpt * deduct shares on exit, make exit pool logic shared, improve names * rename to ExitSwapExactAmountOutExtension * comment out TestNewExitSwapShareAmountInCmd * fix ExitSwapExactAmountOut by truncating int on return from calcPoolSharesInGivenSingleAssetOut * revert x/gamm/cli_test.go to original state with TestNewExitSwapExternAmountOutCmd uncommented * uncomment ExitSwapExactAmountOut in TestActiveBalancerPool * change variable name to exitingCoins * fmt * Update x/gamm/keeper/pool_service.go * Update x/gamm/pool-models/balancer/amm.go * Update x/gamm/keeper/pool_service.go Co-authored-by: Aleksandr Bezobchuk <[email protected]>
* superfluid staking docs * superfluid staking docs Co-authored-by: Xiangan He <[email protected]>
* Update archivenode.bash * Update archivenode.bash * Update archivenode.bash
* update all builders * rbuilder images are prefixed by osmolabs * update makefile * use root instead of builder user and other minor changes * correct lib path in Makefile * LINK_STATICALLY in Makefile * docs for builder * update README * changelog entry * remove make clean from .build.sh * improve readme * remove spurious whitespace in Makefile * fix formatting for build-reproducible * update cosmwasm path in makefile * copy from /home/builder in build-reproducible * change wasm file pemissions to non-root
* Diagram for superfluid staking Moving the diagram to this repo from the docs repo. WIP * adding diagram image * removed diagram, moved to chain repo * add superfluid diagram
github-actions
bot
added
C:CLI
C:x/claim
C:x/gamm
|
Thanks for making this! Could you just PR the removal of the claims module commit to main? I think we should just cut should hopefully just be We want all commits to feature release branches to be done via labels and the backport bot, unless explicitly needed otherwise. |
|
Sure! So for now it is OK to make state breaking changes to main? When I make that PR, should I keep the v8 's ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1299
Description
This pr removes the claim module and its base branch is v8.x because it contains state-breaking changes.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer