Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: CLI account-locked-duration #1292
Feat: CLI account-locked-duration #1292
Changes from all commits
7d39255
7323906
85f1c3c
c728281
38d1180
3fbb784
3c6c6d1
4728be4
5a4d7a1
e8bf393
93fd8c3
d09b708
7a830c6
5a15cd5
df3b68f
316fe43
1108c1a
066727f
9bd7ff6
dfe4272
50b1acc
5d31a26
e92923d
fe85f63
c08a216
44350e1
da8ce5f
2678e1b
d635e43
ad523ac
ce4a764
77891d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
AccountLockedDurationRequest
defines the query params, is there a point in having{owner}
as part of the resource URL?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this?
AccountLockedPastTimeDenom
,AccountLockedPastTimeNotUnlockingOnlyRequest
, and most of the locked RPC commands have the {owner} within the resource URL, I had assumed it was for the address parameter and maintained practice.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderbez I'm not very familiar with this RPC library - does it make sense for us to create an issue and remove potentially redundant
{owner}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These urls are mostly used in front end, but we definitely don't need to have them both in the request url and the request itself. However, I don't know if it's worth changing considering the fact that all the urls and queries in the frontend would have to be updated along as well