Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmd to v0.24.0 #1107

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Update wasmd to v0.24.0 #1107

merged 2 commits into from
Mar 16, 2022

Conversation

ValarDragon
Copy link
Member

Update wasmd to v0.24.0

cc @nikever , this will require updating the wasmvm version for main


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon requested a review from ethanfrey March 16, 2022 16:18
@niccoloraspa
Copy link
Member

Thanks for the heads up, I'll check the required updates

@codecov-commenter
Copy link

Codecov Report

Merging #1107 (161dac0) into main (53b253f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   20.94%   20.94%           
=======================================
  Files         199      199           
  Lines       25429    25429           
=======================================
  Hits         5326     5326           
  Misses      19140    19140           
  Partials      963      963           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b253f...161dac0. Read the comment docs.

@ValarDragon
Copy link
Member Author

Going to go ahead and merge to give people working on Osmosis a better development UX if their on an M1 mac.

This updates the wasmvm version from v1.0.0-beta5 to v1.0.0-beta7. It appears to me that the Dockerfile is already on beta7, which means it would be building a binary with an incompatible wasmvm version from mainnet. And therefore would get a state error when the first cosmwasm contract gets on mainnet. But also means that no changes are needed to get it working for this!

@ValarDragon ValarDragon merged commit b688c4a into main Mar 16, 2022
@ValarDragon ValarDragon deleted the dev/update_wasmd branch March 16, 2022 16:52
@ethanfrey
Copy link
Contributor

Not needed, but you can also test builds on Darwin arm64 if you want to try...
Just made that PR #1109

@p0mvn p0mvn added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 28, 2022
mergify bot pushed a commit that referenced this pull request Mar 28, 2022
* Update wasmd to v0.24.0

* Update changelog

(cherry picked from commit b688c4a)

# Conflicts:
#	CHANGELOG.md
#	go.sum
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants