Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register message server on osmosis modules #1095

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ValarDragon
Copy link
Member

Closes #1093

We already did this on the gamm module before. No other module has new message types.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon requested a review from mattverse March 15, 2022 01:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #1095 (c9379d7) into main (86b4836) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   20.91%   20.94%   +0.02%     
==========================================
  Files         199      199              
  Lines       25426    25429       +3     
==========================================
+ Hits         5319     5326       +7     
+ Misses      19144    19140       -4     
  Partials      963      963              
Impacted Files Coverage Δ
x/incentives/module.go 55.55% <100.00%> (+1.01%) ⬆️
x/lockup/module.go 56.81% <100.00%> (+1.00%) ⬆️
x/superfluid/module.go 60.41% <100.00%> (+0.84%) ⬆️
x/superfluid/keeper/msg_server.go 4.54% <0.00%> (+4.54%) ⬆️
x/incentives/keeper/msg_server.go 7.14% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b4836...c9379d7. Read the comment docs.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the comments as well! We should definitely fix comments in other modules as well in the future!

@ValarDragon
Copy link
Member Author

Going to go ahead and merge then! I wish we had some tooling that could automatically test for module misconfigs like this one

@ValarDragon ValarDragon merged commit 956e553 into main Mar 15, 2022
@ValarDragon ValarDragon deleted the dev/register_message_servers branch March 15, 2022 03:51
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Authz doesn't work with some osmosis-specific messages
3 participants