Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis import export check for superfluid #1088

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Genesis import export check for superfluid #1088

merged 1 commit into from
Mar 14, 2022

Conversation

antstalepresh
Copy link
Contributor

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

ValarDragon
ValarDragon approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in isolation. I guess the simulator if setup with enough operations, acts as a better fuzz tester of the import/export procedure

@ValarDragon ValarDragon merged commit 86b4836 into main Mar 14, 2022
@ValarDragon ValarDragon deleted the eugen/superfluid_genesis_import_export_check branch March 14, 2022 19:48
@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 14, 2022
mergify bot pushed a commit that referenced this pull request Mar 14, 2022
@antstalepresh
genesis import export check for superfluid (#1088)
908cd74 
(cherry picked from commit 86b4836)

# Conflicts:
#	x/superfluid/genesis.go
@mergify mergify bot mentioned this pull request Mar 14, 2022
Merged
ValarDragon pushed a commit that referenced this pull request Mar 15, 2022
@mergify @antstalepresh
Genesis import export check for superfluid (backport #1088) (#1094)
5b4adf7 
* genesis import export check for superfluid (#1088)

(cherry picked from commit 86b4836)

# Conflicts:
#	x/superfluid/genesis.go

* resolve conflict

Co-authored-by: antstalepresh <[email protected]>
Co-authored-by: antstalepresh <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antstalepresh @ValarDragon