Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluid Misc: Improve grpc_query (backport #1084) #1085

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 14, 2022

This is an automatic backport of pull request #1084 done by Mergify.
Cherry-pick of 052bc20 has failed:

On branch mergify/bp/v7.x/pr-1084
Your branch is up to date with 'origin/v7.x'.

You are currently cherry-picking commit 052bc20.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/superfluid/keeper/grpc_query.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/superfluid/keeper/grpc_query_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix Query for empty connected intermediary account

* Improve superfluid grpc-query

(cherry picked from commit 052bc20)

# Conflicts:
#	x/superfluid/keeper/grpc_query_test.go
@mergify mergify bot added the conflicts label Mar 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1085 (a4bbe0b) into v7.x (86bafe3) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v7.x    #1085      +/-   ##
==========================================
- Coverage   20.63%   20.56%   -0.07%     
==========================================
  Files         193      193              
  Lines       25264    25465     +201     
==========================================
+ Hits         5214     5238      +24     
- Misses      19095    19273     +178     
+ Partials      955      954       -1     
Impacted Files Coverage Δ
x/superfluid/keeper/grpc_query.go 56.28% <100.00%> (+9.73%) ⬆️
x/incentives/types/gauge.pb.go 0.74% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bafe3...a4bbe0b. Read the comment docs.

@mattverse mattverse requested a review from ValarDragon March 14, 2022 04:37
@mattverse mattverse merged commit fe1bfd2 into v7.x Mar 14, 2022
@mattverse mattverse deleted the mergify/bp/v7.x/pr-1084 branch March 14, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants