-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genesis upgrade and add invariant cherry pick (backport #1081) #1082
Conversation
* add TotalSuperfluidDelegationInvariant * update invariant name * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * revert back changes for SetLockIdIntermediaryAccountConnection * convert to round * add invariant checker function call on all superfluid tests * update go mod/sum * add after validator slashed hook * following updates for main branch cherry-pick Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit a454116) # Conflicts: # go.sum # x/superfluid/keeper/slash_test.go
x/superfluid/module.go
Outdated
@@ -157,7 +157,9 @@ func (am AppModule) RegisterServices(cfg module.Configurator) { | |||
} | |||
|
|||
// RegisterInvariants registers the capability module's invariants. | |||
func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} | |||
func (am AppModule) RegisterInvariants(ir sdk.InvariantRegistry) { | |||
keeper.RegisterInvariants(ir, am.keeper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to comment this out
x/superfluid/keeper/hooks.go
Outdated
if slashFactor.IsZero() { | ||
return | ||
} | ||
h.k.RefreshIntermediaryDelegationAmounts(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to comment this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the conflicts!
This is an automatic backport of pull request #1081 done by Mergify.
Cherry-pick of a454116 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com