Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile #1071

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Improve Dockerfile #1071

merged 2 commits into from
Mar 10, 2022

Conversation

niccoloraspa
Copy link
Member

@niccoloraspa niccoloraspa commented Mar 10, 2022

Description

This repository improves our Dockerfile by:

Usage:

docker run --rm -it -v $HOME/.osmosisd/:/osmosis/ osmolabs/osmosis:v7.0.4 <subcommand>

Example:

docker run --rm -it -v $HOME/.osmosisd/:/osmosis/ osmolabs/osmosis:v7.0.4 init my-moniker

You can create an alias to simplify the command:

alias osmosisd="docker run --rm -it -v $HOME/.osmosisd/:/osmosis/ osmolabs/osmosis:v7.0.4"

and then simply:

osmosisd init my-moniker 

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1071 (6cb0521) into main (9f64276) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   20.64%   20.64%           
=======================================
  Files         193      193           
  Lines       25270    25270           
=======================================
  Hits         5218     5218           
  Misses      19096    19096           
  Partials      956      956           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f64276...6cb0521. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome! Should we add the docker alias somewhere to the docs /README as well, to make people more aware of it? cc @czarcas7ic

@czarcas7ic
Copy link
Member

Will sync with Nicco on this to make it happen, thanks

osmosis-labs/docs#44

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 10, 2022
@ValarDragon ValarDragon merged commit 8bbfd24 into osmosis-labs:main Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
* Use nonroot docker image

* Update CHANGELOG.md

(cherry picked from commit 8bbfd24)
ValarDragon pushed a commit that referenced this pull request Mar 10, 2022
* Use nonroot docker image

* Update CHANGELOG.md

(cherry picked from commit 8bbfd24)

Co-authored-by: Niccolo Raspa <[email protected]>
@niccoloraspa niccoloraspa deleted the feat/improve-docker-image branch March 16, 2022 10:24
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants