Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Superfluid Params Query #1063

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Add Superfluid Params Query #1063

merged 4 commits into from
Mar 9, 2022

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Mar 9, 2022

Modified ParamsRequest/Response to QueryParamsRequest/Response to keep with format.

Modified respective protos, tested on client node with valid response

minimum_risk_factor: "0.500000000000000000"

We still might need to rename this param as discussed previously (as per Path's suggestion on discord), but at least we can display on CLI now.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1063 (ee3e64e) into main (6e21725) will decrease coverage by 0.01%.
The diff coverage is 5.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   20.66%   20.64%   -0.02%     
==========================================
  Files         193      193              
  Lines       25251    25270      +19     
==========================================
  Hits         5218     5218              
- Misses      19077    19096      +19     
  Partials      956      956              
Impacted Files Coverage Δ
x/superfluid/client/cli/query.go 0.00% <0.00%> (ø)
x/superfluid/keeper/grpc_query.go 46.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e21725...ee3e64e. Read the comment docs.

@czarcas7ic czarcas7ic changed the title Superfluid Params Query Add Superfluid Params Query Mar 9, 2022
@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 9, 2022
@ValarDragon ValarDragon merged commit 9f64276 into main Mar 9, 2022
@ValarDragon ValarDragon deleted the adam/sf-query branch March 9, 2022 22:37
mergify bot pushed a commit that referenced this pull request Mar 9, 2022
* sf params

* query proto change

* added generated proto

* keeper updates

(cherry picked from commit 9f64276)
ValarDragon pushed a commit that referenced this pull request Mar 9, 2022
* sf params

* query proto change

* added generated proto

* keeper updates

(cherry picked from commit 9f64276)

Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants