-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eugen/cherry pick superfluid test scaffolding updates #1052
Eugen/cherry pick superfluid test scaffolding updates #1052
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 20.60% 20.69% +0.08%
==========================================
Files 193 193
Lines 25237 25258 +21
==========================================
+ Hits 5199 5226 +27
+ Misses 19084 19078 -6
Partials 954 954
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change for code sanity requested, otherwise LGTM!
Co-authored-by: Matt, Park <[email protected]>
Your suggestion is merged and checked the test pass |
* add utility for SetupGammPoolsAndSuperfluidAssets * remove hardcoded gamm pool denoms * fix for main branch ctx => Ctx, app => App in tests * Update x/superfluid/keeper/stake_test.go Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit f375c5a)
* add utility for SetupGammPoolsAndSuperfluidAssets * remove hardcoded gamm pool denoms * fix for main branch ctx => Ctx, app => App in tests * Update x/superfluid/keeper/stake_test.go Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit f375c5a) Co-authored-by: antstalepresh <[email protected]>
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer